fix(autoware_universe_utils): fix constParameterReference #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
…erReference_com-1
kobayu858
requested review from
soblin,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kobayu858
added
the
run:build-and-test-differential
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
…om:team-emb4/autoware.universe into fix/cppcheck_constParameterReference_com-1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7882 +/- ##
==========================================
- Coverage 28.44% 27.99% -0.46%
==========================================
Files 1591 1644 +53
Lines 116213 119098 +2885
Branches 49613 50137 +524
==========================================
+ Hits 33059 33336 +277
- Misses 74141 76654 +2513
- Partials 9013 9108 +95
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Jul 8, 2024
veqcc
approved these changes
Jul 9, 2024
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…undation#7882) * fix: constParameterReference Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix: constParameterReference Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> --------- Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix based on cppcheck constParameterReference warnings
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.