Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt_yolox): fix cstyleCast to reinterpret_cast #7873

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

Koichi98
Copy link
Contributor

@Koichi98 Koichi98 commented Jul 5, 2024

Description

This is a fix based on cppcheck warning.

autoware.universe/perception/tensorrt_yolox/src/tensorrt_yolox.cpp:1208:5: style: C-style pointer casting [cstyleCast]
    (unsigned char *)argmax_buf_d_.get() + index, d_prob, out_w, out_h, width, height, classes, 1,
    ^

Fixed this cstyle cast to reinterpret_cast.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>
@Koichi98 Koichi98 requested review from dan-dnn and manato as code owners July 5, 2024 09:23
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 5, 2024
@Koichi98 Koichi98 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 5, 2024
@Koichi98 Koichi98 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 8, 2024
@Koichi98 Koichi98 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.42%. Comparing base (e1cd1da) to head (9672003).
Report is 1 commits behind head on main.

Files Patch % Lines
perception/tensorrt_yolox/src/tensorrt_yolox.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7873      +/-   ##
==========================================
- Coverage   28.43%   28.42%   -0.01%     
==========================================
  Files        1589     1588       -1     
  Lines      116187   116196       +9     
  Branches    49548    49551       +3     
==========================================
- Hits        33034    33032       -2     
- Misses      74159    74169      +10     
- Partials     8994     8995       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.43% <ø> (-0.01%) ⬇️ Carriedforward from e1cd1da

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koichi98
I appreciate your contribution to improve the quality. LGTM!

@Koichi98 Koichi98 merged commit 833deea into autowarefoundation:main Jul 11, 2024
40 of 42 checks passed
@Koichi98 Koichi98 deleted the cstyleCast_tensorrt_yolox branch July 11, 2024 08:06
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…dation#7873)

* fix(tensorrt_yolox): fix cstyleCast to reinterpret_cast

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>

* style(pre-commit): autofix

* fix(tensorrt_yolox): fix cstyleCast to reinterpret_cast

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants