refactor(crosswalk): clean up the structure and create a brief flowchart #7868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
takayuki5168
added
the
run:deploy-docs
takayuki5168
force-pushed
the
refactor/crosswalk-flow
branch
from
ddd01d4 to
01a9101
Compare
takayuki5168
added
the
run:build-and-test-differential
takayuki5168
requested review from
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
tkimura4 and
yuki-takagi-66
as code owners
takayuki5168
force-pushed
the
refactor/crosswalk-flow
branch
from
bfca260 to
a7cb680
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7868 +/- ##
==========================================
- Coverage 28.95% 28.92% -0.04%
==========================================
Files 1606 1611 +5
Lines 117597 117650 +53
Branches 50604 50610 +6
==========================================
- Hits 34047 34027 -20
- Misses 74359 74486 +127
+ Partials 9191 9137 -54
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yuki-takagi-66
approved these changes
Jul 16, 2024
| :applySlowDownByOcclusion; | ||
| end group | ||
| group calculate stop pose | ||
| :getStaticStopPose; |
There was a problem hiding this comment.
I prefer the conventional name "default stop pose", but the new name static stop pose is good one to merge as well.
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
force-pushed
the
refactor/crosswalk-flow
branch
from
a2ae07f to
9cc9086
Compare
yhisaki
pushed a commit
to yhisaki/autoware.universe
that referenced
this pull request
Jul 19, 2024
…art (autowarefoundation#7868) * refactor(crosswalk): clean up the structure and create a brief flowchart Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * static stop pose -> default stop pose Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…art (autowarefoundation#7868) * refactor(crosswalk): clean up the structure and create a brief flowchart Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * static stop pose -> default stop pose Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 23, 2024
…art (autowarefoundation#7868) * refactor(crosswalk): clean up the structure and create a brief flowchart Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * static stop pose -> default stop pose Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: chtseng <chtseng@itri.org.tw>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…art (autowarefoundation#7868) * refactor(crosswalk): clean up the structure and create a brief flowchart Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * static stop pose -> default stop pose Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clean up the structure and create a brief flowchart
Related links
How was this PR tested?
scenario test:
https://evaluation.tier4.jp/evaluation/reports/43f87901-7267-566d-9f08-fb27c1191175?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.