Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): don't automatically avoid ambiguous vehicle #7851

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 4, 2024

Description

Add new option to select behavior policy for the vehicle this module can't judge if it's a parked vehicle or not.

Policy: auto

If user set auto policy, this module avoids such a ambiguous vehicle automatically.

simplescreenrecorder-2024-07-10_08.49.30.mp4

Policy: manual

If user set manual policy, this module generates avoidance candidate path and keeps waiting execution until operator approves it.

simplescreenrecorder-2024-07-10_10.41.36.mp4

Policy: ignore

If user set ignore policy, this module never avoids such a ambiguous vehicle.

simplescreenrecorder-2024-07-10_10.59.51.mp4

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota force-pushed the feat/ambiguous-vehicle branch 2 times, most recently from 46172ea to a9f3f06 Compare July 9, 2024 22:59
…ehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes missing coverage. Please review.

Project coverage is 28.73%. Comparing base (050fa29) to head (ad216a8).
Report is 17 commits behind head on main.

Files Patch % Lines
...r_path_static_obstacle_avoidance_module/helper.hpp 0.00% 12 Missing ⚠️
...ath_static_obstacle_avoidance_module/src/utils.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7851      +/-   ##
==========================================
- Coverage   28.74%   28.73%   -0.01%     
==========================================
  Files        1593     1594       +1     
  Lines      116848   116822      -26     
  Branches    50027    50012      -15     
==========================================
- Hits        33586    33573      -13     
+ Misses      74221    74211      -10     
+ Partials     9041     9038       -3     
Flag Coverage Δ *Carryforward flag
differential 13.60% <35.71%> (?)
total 28.73% <ø> (-0.01%) ⬇️ Carriedforward from 050fa29

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 2e76976 into autowarefoundation:main Jul 10, 2024
38 of 39 checks passed
@satoshi-ota satoshi-ota deleted the feat/ambiguous-vehicle branch July 10, 2024 10:18
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…ehicle (autowarefoundation#7851)

* fix(static_obstacle_avoidance): don't automatically avoid ambiguous vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(schema): update schema

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 29, 2024
…ehicle (autowarefoundation#7851)

* fix(static_obstacle_avoidance): don't automatically avoid ambiguous vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(schema): update schema

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 31, 2024
…ehicle (autowarefoundation#7851)

* fix(static_obstacle_avoidance): don't automatically avoid ambiguous vehicle

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(schema): update schema

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants