Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static_obstacle_avoidance): show markers when system requests operator support #7994

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 12, 2024

Description

Show marker for operator when system requests cooperation. This marker is published only when the user set policy of ego behavior for ambiguous situation to manual.

        avoidance_for_ambiguous_vehicle:
          # policy for ego behavior for ambiguous vehicle.
          # "auto"   : generate candidate path. if RTC is running as AUTO mode, the ego avoids it automatically.
          # "manual" : generate candidate path and wait operator approval even if RTC is running as AUTO mode.
          # "ignore" : never avoid it.
          policy: "manual"                                # [-]

Topic: /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/info/static_obstacle_avoidance

Screenshot from 2024-07-12 13-17-49

Additionally, I updated marker color for ignored objects to Gray from Green.

Topic: /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/static_obstacle_avoidance

Screenshot from 2024-07-12 14-06-27

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…erator support

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 16, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) July 16, 2024 04:05
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 9.75610% with 37 lines in your changes missing coverage. Please review.

Project coverage is 28.92%. Comparing base (65c039d) to head (5cf7a40).
Report is 12 commits behind head on main.

Files Patch % Lines
...ath_static_obstacle_avoidance_module/src/debug.cpp 2.63% 36 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7994      +/-   ##
==========================================
- Coverage   28.93%   28.92%   -0.01%     
==========================================
  Files        1601     1602       +1     
  Lines      117270   117329      +59     
  Branches    50302    50325      +23     
==========================================
+ Hits        33933    33941       +8     
- Misses      74175    74226      +51     
  Partials     9162     9162              
Flag Coverage Δ *Carryforward flag
differential 13.59% <9.75%> (?)
total 28.93% <ø> (+<0.01%) ⬆️ Carriedforward from 65c039d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 544f6e7 into autowarefoundation:main Jul 16, 2024
39 checks passed
@satoshi-ota satoshi-ota deleted the feat/marker-operator-support branch July 16, 2024 04:34
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…erator support (autowarefoundation#7994)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 29, 2024
…erator support (autowarefoundation#7994)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 31, 2024
…erator support (autowarefoundation#7994)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants