fix(autoware_map_based_prediction): fix syntaxError

[veqcc]

Description

This is a fix based on cppcheck syntaxError error.

perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp:1774:16: error: The code contains unhandled character(s) (character code=206). Neither unicode nor extended ascii is supported. [syntaxError]
  const double λ = std::log(2) / acceleration_exponential_half_life_;
               ^
perception/autoware_map_based_prediction/src/path_generator.cpp:424:15: error: The code contains unhandled character(s) (character code=206). Neither unicode nor extended ascii is supported. [syntaxError]
  const float λ = std::log(2) / acceleration_exponential_half_life_;
              ^

Changes are only renaming λ to lambda.

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[kyoichi-sugahara]

LGTM!

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 28.54%. Comparing base (fbbc44c) to head (2ad9c58).

Files	Patch %	Lines
...toware_map_based_prediction/src/path_generator.cpp	0.00%	9 Missing ⚠️
...based_prediction/src/map_based_prediction_node.cpp	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7813      +/-   ##
==========================================
- Coverage   28.55%   28.54%   -0.01%     
==========================================
  Files        1586     1588       +2     
  Lines      115879   115917      +38     
  Branches    49384    49387       +3     
==========================================
  Hits        33093    33093              
- Misses      73823    73861      +38     
  Partials     8963     8963              

Flag	Coverage Δ		*Carryforward flag
differential	1.15% <0.00%> (?)
total	28.56% <ø> (+<0.01%)	⬆️	Carriedforward from 4e90378

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[veqcc]

@kyoichi-sugahara

The cppcheck raises the following new warnings.
This is because the syntaxError has been preventing cppcheck to analyze these files properly so far.

Error: /home/runner/work/autoware.universe/autoware.universe/perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp:1779:53: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall]
      obj_acc * (1.0 / std::pow(lambda, 2)) * (std::exp(-lambda * t_h) - 1);
                                                    ^
Error: /home/runner/work/autoware.universe/autoware.universe/perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp:1[7](https://github.com/autowarefoundation/autoware.universe/actions/runs/9779459222/job/26998789870?pr=7813#step:12:8)97:53: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall]
      obj_acc * (1.0 / std::pow(lambda, 2)) * (std::exp(-lambda * t_f) - 1) + obj_vel * t_f +
                                                    ^
Error: /home/runner/work/autoware.universe/autoware.universe/perception/autoware_map_based_prediction/src/path_generator.cpp:450:44: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall]
      auto t_stop = (-1.0 / lambda) * std::log(1 + (v * lambda / a));
                                           ^
Error: /home/runner/work/autoware.universe/autoware.universe/perception/autoware_map_based_prediction/src/path_generator.cpp:455:4[9](https://github.com/autowarefoundation/autoware.universe/actions/runs/9779459222/job/26998789870?pr=7813#step:12:10): style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall]
        a * (1.0 / std::pow(lambda, 2)) * (std::exp(-lambda * t_h) - 1);
                                                ^
Error: /home/runner/work/autoware.universe/autoware.universe/perception/autoware_map_based_prediction/src/path_generator.cpp:466:56: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall]
             (a / (t_h * std::pow(lambda, 2))) * (std::exp(-lambda * t_h) - 1);
                                                       ^
Error: /home/runner/work/autoware.universe/autoware.universe/perception/autoware_map_based_prediction/src/path_generator.cpp:476:74: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall]
      a * (1.0 / lambda) * t_f + a * (1.0 / std::pow(lambda, 2)) * (std::exp(-lambda * t_f) - 1) +
                                                                         ^

[kyoichi-sugahara]

@veqcc

The cppcheck raises the following new warnings.

It's not funny, but I laughed at the interesting behavior.
I think the new changes are still LGTM 👍

[veqcc]

Thank you!