Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lidar_centerpoint): added gtest for the cuda related parts of centerpoint #7125

Merged
merged 5 commits into from
May 30, 2024

style(pre-commit): autofix

7548f06
Select commit
Loading
Failed to load commit list.
Merged

test(lidar_centerpoint): added gtest for the cuda related parts of centerpoint #7125

style(pre-commit): autofix
7548f06
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 27, 2024 in 29s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 6 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Assertion Blocks test_preprocess_kernel.cpp
  • Code Duplication test_preprocess_kernel.cpp
  • Large Method test_postprocess_kernel.cpp: TEST:PostprocessKernelTest:CircleNMSTest
  • Large Method test_preprocess_kernel.cpp: TEST:PreprocessKernelTest:VoxelOverflowTest
  • Large Method test_preprocess_kernel.cpp: TEST:PreprocessKernelTest:BasicTest
  • Large Method test_postprocess_kernel.cpp: TEST:PostprocessKernelTest:SingleDetectionTest

Annotations

Check warning on line 359 in perception/lidar_centerpoint/test/test_postprocess_kernel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TEST:PostprocessKernelTest:CircleNMSTest has 105 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 178 in perception/lidar_centerpoint/test/test_postprocess_kernel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TEST:PostprocessKernelTest:SingleDetectionTest has 76 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 119 in perception/lidar_centerpoint/test/test_preprocess_kernel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: TEST:PreprocessKernelTest:EmptyVoxelTest,TEST:PreprocessKernelTest:OutOfRangeTest. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 395 in perception/lidar_centerpoint/test/test_preprocess_kernel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TEST:PreprocessKernelTest:VoxelOverflowTest has 102 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 234 in perception/lidar_centerpoint/test/test_preprocess_kernel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TEST:PreprocessKernelTest:BasicTest has 81 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 234 in perception/lidar_centerpoint/test/test_preprocess_kernel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Assertion Blocks

The test suite contains 8 assertion blocks with at least 4 assertions, threshold = 4. This test file has several blocks of large, consecutive assert statements. Avoid adding more.