Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner_common): update RTC state to SUCCEEDED #7119

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented May 24, 2024

Description

Support for new RTC state transition.
It updates RTC state to State::SUCCEEDED if the module exits with ModuleStatus::SUCCESS.

Applying to avoidance module is a future work.

Related links

Tests performed

TIER IV INTERNAL TEST

I checked that the state in /planning/cooperate_status/** changes from RUNNING = 1 to SUCCEEDED = 3.

Lane change

Screencast.from.2024.05.27.11.17.04.webm

Start planner

Screencast.from.2024.05.27.11.18.45.webm

Notes for reviewers

Interface changes

ROS Topic Changes

Not applicable.

ROS Parameter Changes

Not applicable.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 24, 2024
@rej55 rej55 marked this pull request as ready for review May 27, 2024 02:25
@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 27, 2024
@rej55 rej55 merged commit 92b5114 into autowarefoundation:main May 27, 2024
35 of 37 checks passed
@rej55 rej55 deleted the fix/update_rtc_state_to_succeeded branch May 27, 2024 05:46
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jun 9, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jun 11, 2024
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Jun 11, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants