perf(mission_planner): remove queries on all road and shoulder lanelets #7079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No longer query ALL road and shoulder lanelets in the mission_planner.
There was an issue in the previous PR #7024 with the
RoutingGraph
used by the mission planner. When checking if a goal fits inside the lane, we need to retrieve the lanelets following the closest lanelet to the goal. For some reason there were cases where, for the same input lanelet, theRoutingGraph::following(lanelet)
function would return different value and some valid goal would become invalid.I refactored the mission planner to not directly use the routing graph, but instead use the
route_handler
to achieve the same operation. This fixed the issue (see the evaluation results) but I still do not understand the original problem.Tests performed
Psim.
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/c27675c8-314b-515d-b469-75eea198c448?project_id=prd_jt
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.