Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(mission_planner): remove queries on all road and shoulder lanelets #7079

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented May 21, 2024

Description

No longer query ALL road and shoulder lanelets in the mission_planner.

There was an issue in the previous PR #7024 with the RoutingGraph used by the mission planner. When checking if a goal fits inside the lane, we need to retrieve the lanelets following the closest lanelet to the goal. For some reason there were cases where, for the same input lanelet, the RoutingGraph::following(lanelet) function would return different value and some valid goal would become invalid.
I refactored the mission planner to not directly use the routing graph, but instead use the route_handler to achieve the same operation. This fixed the issue (see the evaluation results) but I still do not understand the original problem.

Tests performed

Psim.
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/c27675c8-314b-515d-b469-75eea198c448?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels May 21, 2024
@maxime-clem maxime-clem merged commit aa8767b into autowarefoundation:main May 21, 2024
40 of 44 checks passed
@maxime-clem maxime-clem deleted the perf/mission_planner-rm-all_lanelets branch May 21, 2024 05:52
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ts (autowarefoundation#7079)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants