perf(mission_planner): remove queries on all road and shoulder lanelets #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-clem
requested review from
isamu-takagi,
kosuke55,
soblin,
mitsudome-r,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:planning
maxime-clem
changed the title
maxime-clem
added
the
run:build-and-test-differential
takayuki5168
approved these changes
May 17, 2024
maxime-clem
force-pushed
the
perf/mission_planner-rm-all_lanelets
branch
from
f01711e to
7fc3418
Compare
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
force-pushed
the
perf/mission_planner-rm-all_lanelets
branch
from
7fc3418 to
76db48e
Compare
maxime-clem
requested review from
rej55,
go-sakayori and
zulfaqar-azmi-t4
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7024 +/- ##
==========================================
+ Coverage 15.01% 15.29% +0.27%
==========================================
Files 1972 1964 -8
Lines 136512 137081 +569
Branches 42308 43085 +777
==========================================
+ Hits 20494 20963 +469
+ Misses 93265 93113 -152
- Partials 22753 23005 +252
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
force-pushed
the
perf/mission_planner-rm-all_lanelets
branch
from
9293608 to
76db48e
Compare
soblin
approved these changes
May 20, 2024
|
There are a few degradation in the scenario test. I will reopen the PR when they are fixed. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No longer query ALL road and shoulder lanelets in the
mission_planner.Tests performed
Psim.
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/c27675c8-314b-515d-b469-75eea198c448?project_id=prd_jt
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.