Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(mission_planner): remove queries on all road and shoulder lanelets #7024

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented May 15, 2024

Description

No longer query ALL road and shoulder lanelets in the mission_planner.

Tests performed

Psim.
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/c27675c8-314b-515d-b469-75eea198c448?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 15, 2024
@maxime-clem maxime-clem changed the title perf(mission_planner): perf(mission_planner): remove queries on all road and shoulder lanelets May 15, 2024
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 15, 2024
@maxime-clem maxime-clem force-pushed the perf/mission_planner-rm-all_lanelets branch from f01711e to 7fc3418 Compare May 17, 2024 04:16
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the perf/mission_planner-rm-all_lanelets branch from 7fc3418 to 76db48e Compare May 19, 2024 11:11
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 21.87500% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 15.29%. Comparing base (010965b) to head (9293608).
Report is 71 commits behind head on main.

Current head 9293608 differs from pull request most recent head 76db48e

Please upload reports for the commit 76db48e to get more accurate results.

Files Patch % Lines
...n_planner/src/lanelet2_plugins/default_planner.cpp 21.05% 5 Missing and 10 partials ⚠️
...planner/src/lanelet2_plugins/utility_functions.cpp 33.33% 2 Missing and 4 partials ⚠️
planning/route_handler/src/route_handler.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7024      +/-   ##
==========================================
+ Coverage   15.01%   15.29%   +0.27%     
==========================================
  Files        1972     1964       -8     
  Lines      136512   137081     +569     
  Branches    42308    43085     +777     
==========================================
+ Hits        20494    20963     +469     
+ Misses      93265    93113     -152     
- Partials    22753    23005     +252     
Flag Coverage Δ *Carryforward flag
differential 14.75% <21.87%> (?)
total 15.10% <ø> (+0.09%) ⬆️ Carriedforward from 017b3fb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem force-pushed the perf/mission_planner-rm-all_lanelets branch from 9293608 to 76db48e Compare May 20, 2024 00:38
@maxime-clem
Copy link
Contributor Author

There are a few degradation in the scenario test. I will reopen the PR when they are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants