chore(simple_planning_simulator): publish control mode before the self-position is given #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-position is given Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4
added
the
run:build-and-test-differential
github-actions
bot
added
the
component:simulation
TakaHoribe
approved these changes
May 15, 2024
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…f-position is given (autowarefoundation#7008) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2024
…f-position is given (autowarefoundation#7008) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Merged
4 tasks
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2024
#1302) chore(simple_planning_simulator): publish control mode before the self-position is given (autowarefoundation#7008) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…f-position is given (autowarefoundation#7008) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when using the Planning_simulator, /vehicle/status/control_mode is not published until the vehicle's position is provided. However, in actual vehicle usage, /vehicle/status/control_mode is published immediately after the vehicle_interface and the vehicle start up (ex. pacmod_interface) . To align the Planning_simulator with this actual behavior, I have modified it to publish /vehicle/status/control_mode immediately after the node starts.
(TIER IV Internal Slack Link )
Tests performed
I confirmed that the /vehicle/status/control_mode becomes to be published before the vehicle's position is provided
Effects on system behavior
No effects on the actual vehicle behavior.
Interface changes
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.