Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(planning_test_utils): remove route_handler dependencies #7005

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Removing route handler dependencies from planning_test_utils.
Move function that are used by autoware_planning_test_manager to the autoware_planning_test_manager_utils.hpp

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels May 14, 2024
zulfaqar-azmi-t4 and others added 2 commits May 16, 2024 09:19
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the planning-test-manager-remove-route-handler branch from 972d3cd to 851e1b7 Compare May 16, 2024 00:19
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label May 16, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title Planning test manager remove route handler refactor(planning_test_utils): remove route_handler dependencies May 16, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review May 16, 2024 00:20
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 16, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) May 16, 2024 08:42
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit a233cd9 into autowarefoundation:main May 16, 2024
31 of 33 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…owarefoundation#7005)

* refactor(planning_test_utils): remove route_handler dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* style(pre-commit): autofix

* Fix precommit

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the planning-test-manager-remove-route-handler branch June 18, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants