-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rtc_interface)!: add new field to rtc cooperate status #6933
Merged
satoshi-ota
merged 3 commits into
autowarefoundation:main
from
tier4:feat/rtc-add-new-field
May 13, 2024
Merged
feat(rtc_interface)!: add new field to rtc cooperate status #6933
satoshi-ota
merged 3 commits into
autowarefoundation:main
from
tier4:feat/rtc-add-new-field
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a6b542
to
0bfebcc
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
0bfebcc
to
2877834
Compare
afcc1e0
to
2877834
Compare
yuki-takagi-66
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
soblin
approved these changes
May 10, 2024
rej55
approved these changes
May 13, 2024
zulfaqar-azmi-t4
approved these changes
May 13, 2024
kosuke55
approved these changes
May 13, 2024
tkimura4
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…foundation#6933) * feat(rtc_interface): add new field Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bvp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bpp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…foundation#6933) * feat(rtc_interface): add new field Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bvp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bpp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…foundation#6933) * feat(rtc_interface): add new field Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bvp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bpp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 11, 2024
…foundation#6933) * feat(rtc_interface): add new field Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bvp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bpp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
shmpwk
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 11, 2024
go-sakayori
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 1, 2024
…foundation#6933) * feat(rtc_interface): add new field Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bvp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(bpp): support new rtc cooperate status Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added new field to
tier4_rtc_msgs/CooperateStatus
msgs.Related links
tier4/tier4_autoware_msgs#119
Tests performed
Notes for reviewers
Please update
tier4_autoware_msgs
to latest one including tier4/tier4_autoware_msgs#119.Interface changes
Update rtc cooperate status msg type in tier4/tier4_autoware_msgs#119.
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.