Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_interface)!: add new field to rtc cooperate status #6933

Merged
merged 3 commits into from
May 13, 2024

feat(bpp): support new rtc cooperate status

2877834
Select commit
Loading
Failed to load commit list.
Merged

feat(rtc_interface)!: add new field to rtc cooperate status #6933

feat(bpp): support new rtc cooperate status
2877834
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded May 10, 2024 in 38s

CodeScene PR Check

✅ Code Health Quality Gates: OK

View detailed results in CodeScene

Details

Annotations

Check notice on line 232 in planning/rtc_interface/src/rtc_interface.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Excess Number of Function Arguments 

RTCInterface::updateCooperateStatus increases from 5 to 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis