Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_run_out): construct predicted path up to max pr… #6650

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Mar 18, 2024

Description

The parameter of max_prediction_time was not applied when Object method is used, so I fixed this.

Related link:
TIER IV INTERNAL

Tests performed

Scenario Test 2791/2811

PSim
max_prediction_time = 10.0 (default value)

run-out-before.mp4

max_prediction_time = 3.0

run-out-after.mp4

Effects on system behavior

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 18, 2024
@TomohitoAndo TomohitoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (152b11e) to head (ec7be50).
Report is 21 commits behind head on main.

Files Patch % Lines
...r_velocity_run_out_module/src/dynamic_obstacle.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6650      +/-   ##
==========================================
+ Coverage   14.78%   14.80%   +0.02%     
==========================================
  Files        1923     1923              
  Lines      132468   132571     +103     
  Branches    39363    39422      +59     
==========================================
+ Hits        19586    19631      +45     
- Misses      91032    91062      +30     
- Partials    21850    21878      +28     
Flag Coverage Δ *Carryforward flag
differential 17.87% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from 0707fcd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo enabled auto-merge (squash) March 19, 2024 06:26
@TomohitoAndo TomohitoAndo merged commit 46ac827 into autowarefoundation:main Mar 19, 2024
26 of 28 checks passed
@TomohitoAndo TomohitoAndo deleted the fix/run-out-max-prediction-time branch March 19, 2024 08:58
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 22, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 22, 2024
#1204)

fix(behavior_velocity_run_out): construct predicted path up to max pr… (autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method



* handle division by zero



* add missing include



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Mar 22, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 11, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 12, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 12, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 12, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
saka1-s pushed a commit to tier4/autoware.universe that referenced this pull request Apr 12, 2024
#1254)

fix(behavior_velocity_run_out): construct predicted path up to max pr… (autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method



* handle division by zero



* add missing include



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
autowarefoundation#6650)

* fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* handle division by zero

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing include

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants