-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_run_out): construct predicted path up to max pr… #6650
Merged
TomohitoAndo
merged 3 commits into
autowarefoundation:main
from
TomohitoAndo:fix/run-out-max-prediction-time
Mar 19, 2024
Merged
fix(behavior_velocity_run_out): construct predicted path up to max pr… #6650
TomohitoAndo
merged 3 commits into
autowarefoundation:main
from
TomohitoAndo:fix/run-out-max-prediction-time
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6650 +/- ##
==========================================
+ Coverage 14.78% 14.80% +0.02%
==========================================
Files 1923 1923
Lines 132468 132571 +103
Branches 39363 39422 +59
==========================================
+ Hits 19586 19631 +45
- Misses 91032 91062 +30
- Partials 21850 21878 +28
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shmpwk
reviewed
Mar 18, 2024
takayuki5168
approved these changes
Mar 19, 2024
shmpwk
approved these changes
Mar 19, 2024
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 22, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Merged
4 tasks
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 22, 2024
#1204) fix(behavior_velocity_run_out): construct predicted path up to max pr… (autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method * handle division by zero * add missing include --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 22, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 11, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 12, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 12, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 12, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Merged
4 tasks
saka1-s
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 12, 2024
#1254) fix(behavior_velocity_run_out): construct predicted path up to max pr… (autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method * handle division by zero * add missing include --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
autowarefoundation#6650) * fix(behavior_velocity_run_out): construct predicted path up to max prediction time in object method Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * handle division by zero Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing include Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parameter of
max_prediction_time
was not applied whenObject
method is used, so I fixed this.Related link:
TIER IV INTERNAL
Tests performed
Scenario Test 2791/2811
PSim
max_prediction_time
= 10.0 (default value)run-out-before.mp4
max_prediction_time
= 3.0run-out-after.mp4
Effects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.