Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): add param reconfig to goal planner #6646

Conversation

danielsanchezaran
Copy link
Contributor

Description

Add support for rqt reconfig for the start planner

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 18, 2024
@danielsanchezaran danielsanchezaran marked this pull request as ready for review March 18, 2024 08:15
@danielsanchezaran danielsanchezaran changed the title feat(start_planner): add param reconfig to goal planner feat(goal_planner): add param reconfig to goal planner Mar 18, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 26, 2024
@danielsanchezaran danielsanchezaran enabled auto-merge (squash) March 26, 2024 09:39
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 302 lines in your changes are missing coverage. Please review.

Project coverage is 14.75%. Comparing base (f03f7f2) to head (a340ac2).
Report is 26 commits behind head on main.

Files Patch % Lines
.../behavior_path_goal_planner_module/src/manager.cpp 0.00% 302 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6646      +/-   ##
==========================================
- Coverage   14.78%   14.75%   -0.04%     
==========================================
  Files        1925     1925              
  Lines      132670   132971     +301     
  Branches    39499    39499              
==========================================
  Hits        19620    19620              
- Misses      91082    91383     +301     
  Partials    21968    21968              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from f03f7f2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit 106ee3e into autowarefoundation:main Mar 26, 2024
34 of 39 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/add-param-reconfig-to-goal-planner branch March 26, 2024 10:18
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ation#6646)

* Add param reconfig to goal planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* Using the Warn params is bugged, wont fix

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add comments

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add missing param

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants