-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_auto_perception_rviz_plugin): indicate object orientation, parameter adjustments, bugfix #6469
feat(autoware_auto_perception_rviz_plugin): indicate object orientation, parameter adjustments, bugfix #6469
Conversation
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…indication Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…dicator Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…ed object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marker_ptr->color.r = 1.0; | ||
marker_ptr->color.g = 0.2; | ||
marker_ptr->color.b = 0.4; | ||
marker_ptr->color.r = 0.2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[imo, you can ignore this] If possible, I prefer there are some comments about color description because we can't image color from rgb values :)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6469 +/- ##
==========================================
- Coverage 15.11% 15.11% -0.01%
==========================================
Files 1821 1821
Lines 126147 126177 +30
Branches 38180 38180
==========================================
Hits 19073 19073
- Misses 85686 85716 +30
Partials 21388 21388
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…on, parameter adjustments, bugfix (autowarefoundation#6469) * fix(autoware_auto_perception_rviz_plugin): align marker lifetime Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat(autoware_auto_perception_rviz_plugin): bounding box orientation indication Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): adjust twist covariance color Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): adjust bbox orientation indicator Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): yaw rate marker in predicted object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…on, parameter adjustments, bugfix (#6469) * fix(autoware_auto_perception_rviz_plugin): align marker lifetime Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat(autoware_auto_perception_rviz_plugin): bounding box orientation indication Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): adjust twist covariance color Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): adjust bbox orientation indicator Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): yaw rate marker in predicted object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…on, parameter adjustments, bugfix (autowarefoundation#6469) * fix(autoware_auto_perception_rviz_plugin): align marker lifetime Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat(autoware_auto_perception_rviz_plugin): bounding box orientation indication Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): adjust twist covariance color Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): adjust bbox orientation indicator Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(autoware_auto_perception_rviz_plugin): yaw rate marker in predicted object Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Description
Current bounding box orientation marker (triangle on the front side) is only visible when the object's
orientation_availability
isAVAILABLE
.In the tracker development process, there was necessity to know object orientation even the
orientation_availability
isSIGN_UNKNOWN
.orientation_availability==SIGN_UNKNOWN
orientation_availability==AVAILABLE
&orientation_availability==SIGN_UNKNOWN
Tests performed
The visualization in rviz2 was confirmed.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.