feat(autoware_auto_perception_rviz_plugin): indicate object orientation, parameter adjustments, bugfix #6469
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Feb 21, 2024 in 44s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication object_polygon_detail.cpp
✅ Improving Code Health:
- Primitive Obsession object_polygon_detail.cpp
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Code Duplication
introduced similar code in: calc_2d_bounding_box_bottom_orientation_line_list,calc_bounding_box_orientation_line_list. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 33.33% to 31.91%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Loading