Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_auto_perception_rviz_plugin): indicate object orientation, parameter adjustments, bugfix #6469

fix(autoware_auto_perception_rviz_plugin): yaw rate marker in predict…

3fcf897
Select commit
Loading
Failed to load commit list.
Merged

feat(autoware_auto_perception_rviz_plugin): indicate object orientation, parameter adjustments, bugfix #6469

fix(autoware_auto_perception_rviz_plugin): yaw rate marker in predict…
3fcf897
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 21, 2024 in 44s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication object_polygon_detail.cpp

✅ Improving Code Health:

  • Primitive Obsession object_polygon_detail.cpp

Annotations

Check warning on line 667 in common/autoware_auto_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Code Duplication

introduced similar code in: calc_2d_bounding_box_bottom_orientation_line_list,calc_bounding_box_orientation_line_list. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check notice on line 1 in common/autoware_auto_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Primitive Obsession

The ratio of primitive types in function arguments decreases from 33.33% to 31.91%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.