Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert accel_brake_map_calibrator #6453

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 19, 2024

Description

Revert the accel_brake_map_calibrator from awf/autoware_tools since lexus_description depends on this package.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 19, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review February 19, 2024 16:39
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 879 lines in your changes are missing coverage. Please review.

Comparison is base (9727299) 15.24% compared to head (ac4df24) 15.13%.

Files Patch % Lines
...calibrator/src/accel_brake_map_calibrator_node.cpp 0.00% 871 Missing ⚠️
vehicle/accel_brake_map_calibrator/src/main.cpp 0.00% 6 Missing ⚠️
...map_calibrator/accel_brake_map_calibrator_node.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6453      +/-   ##
==========================================
- Coverage   15.24%   15.13%   -0.11%     
==========================================
  Files        1816     1819       +3     
  Lines      125147   126026     +879     
  Branches    38188    38188              
==========================================
  Hits        19073    19073              
- Misses      84685    85564     +879     
  Partials    21389    21389              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.24% <ø> (ø) Carriedforward from 9727299

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 4792e2c into autowarefoundation:main Feb 19, 2024
32 of 37 checks passed
@takayuki5168 takayuki5168 deleted the fix/revert-accel-brake-map branch February 19, 2024 16:57
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant