chore: remove zenkaku spaces #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
isamu-takagi,
mitsudome-r,
TakaHoribe,
takayuki5168,
shmpwk,
taikitanaka3,
tkimura4,
rej55,
kyoichi-sugahara,
satoshi-ota,
TomohitoAndo,
zulfaqar-azmi-t4,
danielsanchezaran,
soblin,
scepter914,
YoshiRi,
yukkysaito,
ktro2828,
miursh and
mkuri
as code owners
github-actions
bot
added
type:documentation
kosuke55
commented
Feb 19, 2024
| @@ -119,7 +119,7 @@ Trajectory alignTrajectoryWithReferenceTrajectory( | |||
|
|
|||
| // If last point of predicted_trajectory is behind of end of trajectory, erase points which are | |||
| // behind trajectory last point and insert pNew along the predicted_trajectory | |||
| // predicted_trajectory: p1-----//------pN-2-----pN-1-----pN | |||
| // predicted_trajectory: p1-----//------pN-2-----pN-1-----pN | |||
| // trajectory: t1-----//-----tN-1--tN | |||
| // ↓ | |||
| // predicted_trajectory: p1-----//------pN-2-pNew | |||
There was a problem hiding this comment.
@kyoichi-sugahara
is this alignment ok?
There was a problem hiding this comment.
perfect!!!
zenkaku lol
kyoichi-sugahara
approved these changes
Feb 19, 2024
|
WalkthroughThe changes in this pull request involve removing zenkaku spaces (full-width spaces) from comments in the code and documentation. The modifications aim to improve clarity, remove unnecessary comments, or address comment suggestions regarding interface design. These changes do not alter the logic or functionality of the code. Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (11)
- control/control_validator/src/utils.cpp (2)
- perception/multi_object_tracker/include/multi_object_tracker/tracker/model/tracker_base.hpp (1)
- perception/radar_object_tracker/include/radar_object_tracker/tracker/model/tracker_base.hpp (1)
- planning/behavior_path_avoidance_module/README.md (3)
- planning/behavior_path_goal_planner_module/README.md (2)
- planning/behavior_path_goal_planner_module/include/behavior_path_goal_planner_module/goal_searcher.hpp (1)
- planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp (1)
- planning/behavior_path_lane_change_module/README.md (1)
- planning/behavior_path_planner/src/behavior_path_planner_node.cpp (1)
- planning/behavior_velocity_occlusion_spot_module/README.md (1)
- planning/mission_planner/src/mission_planner/mission_planner.cpp (1)
Files ignored due to filter (1)
- perception/map_based_prediction/images/inside_road.svg
Files skipped from review due to trivial changes (10)
- perception/multi_object_tracker/include/multi_object_tracker/tracker/model/tracker_base.hpp
- perception/radar_object_tracker/include/radar_object_tracker/tracker/model/tracker_base.hpp
- planning/behavior_path_avoidance_module/README.md
- planning/behavior_path_goal_planner_module/README.md
- planning/behavior_path_goal_planner_module/include/behavior_path_goal_planner_module/goal_searcher.hpp
- planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp
- planning/behavior_path_lane_change_module/README.md
- planning/behavior_path_planner/src/behavior_path_planner_node.cpp
- planning/behavior_velocity_occlusion_spot_module/README.md
- planning/mission_planner/src/mission_planner/mission_planner.cpp
Review comments generated (1)
- Review: 1
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Comment on lines
+107
to
+110
| // predicted_trajectory: p1-----p2-----p3----//------pN | ||
| // trajectory: t1--------//------tN | ||
| // ↓ | ||
| // predicted_trajectory: pNew--p3----//------pN | ||
| // predicted_trajectory: pNew--p3----//------pN |
There was a problem hiding this comment.
The comments in this code block explain the behavior of the removeFrontTrajectoryPoint function. However, the comments are not aligned properly and contain unnecessary whitespace characters. It would be better to reformat the comments for clarity and remove the extra spaces.
// If first point of predicted_trajectory is in front of start of trajectory, erase points which
// are in front of trajectory start point and insert pNew along the predicted_trajectory
- // predicted_trajectory: p1-----p2-----p3----//------pN
+ // predicted_trajectory: p1-----p2-----p3----//------pN
// trajectory: t1--------//------tN
// ↓
- // predicted_trajectory: pNew--p3----//------pN
+ // predicted_trajectory: pNew--p3----//------pN
// trajectory: t1--------//------tN
auto predicted_trajectory_point_removed = removeFrontTrajectoryPoint(
trajectory_points, modified_trajectory_points, predicted_trajectory_points);122:
The comment in this code block explains the behavior of the removeFrontTrajectoryPoint function. However, the comment is not aligned properly and contains unnecessary whitespace characters. It would be better to reformat the comment for clarity and remove the extra spaces.
// If last point of predicted_trajectory is behind of end of trajectory, erase points which are
// behind trajectory last point and insert pNew along the predicted_trajectory
- // predicted_trajectory: p1-----//------pN-2-----pN-1-----pN
+ // predicted_trajectory: p1-----//------pN-2-----pN-1-----pN
// trajectory: t1-----//-----tN-1--tN
// ↓
// predicted_trajectory: p1-----//------pN-2-pNew
soblin
approved these changes
Feb 19, 2024
miursh
approved these changes
Feb 19, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
chore/zenkaku
branch
from
6245636 to
7467951
Compare
ktro2828
approved these changes
Feb 21, 2024
yukkysaito
approved these changes
Feb 21, 2024
YoshiRi
reviewed
Feb 21, 2024
satoshi-ota
approved these changes
Feb 21, 2024
scepter914
approved these changes
Feb 21, 2024
takayuki5168
approved these changes
Feb 21, 2024
TakaHoribe
approved these changes
Feb 21, 2024
shmpwk
approved these changes
Feb 21, 2024
kosuke55
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6451 +/- ##
==========================================
- Coverage 14.99% 14.81% -0.18%
==========================================
Files 1839 1842 +3
Lines 127213 129522 +2309
Branches 38132 38818 +686
==========================================
+ Hits 19071 19195 +124
- Misses 86808 88819 +2011
- Partials 21334 21508 +174
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove zenkaku spaces
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.
Summary by CodeRabbit
goal_searcher.hppto exclude "freespace pull over" from the efficient order of the pull-over planner along lanes. No impact on logic or functionality.BehaviorPathPlannerNodeclass andMissionPlannerclass. No impact on logic or functionality.