Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove zenkaku spaces #6451

Merged
merged 1 commit into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions control/control_validator/src/utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ Trajectory alignTrajectoryWithReferenceTrajectory(

// If first point of predicted_trajectory is in front of start of trajectory, erase points which
// are in front of trajectory start point and insert pNew along the predicted_trajectory
// predicted_trajectory:     p1-----p2-----p3----//------pN
// predicted_trajectory: p1-----p2-----p3----//------pN
// trajectory: t1--------//------tN
// ↓
// predicted_trajectory:      pNew--p3----//------pN
// predicted_trajectory: pNew--p3----//------pN
Comment on lines +107 to +110

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The comments in this code block explain the behavior of the removeFrontTrajectoryPoint function. However, the comments are not aligned properly and contain unnecessary whitespace characters. It would be better to reformat the comments for clarity and remove the extra spaces.

   // If first point of predicted_trajectory is in front of start of trajectory, erase points which
   // are in front of trajectory start point and insert pNew along the predicted_trajectory
-  // predicted_trajectory:       p1-----p2-----p3----//------pN
+  // predicted_trajectory:           p1-----p2-----p3----//------pN
   // trajectory:                               t1--------//------tN
   // ↓
-  // predicted_trajectory:               pNew--p3----//------pN
+  // predicted_trajectory:                   pNew--p3----//------pN
   // trajectory:                               t1--------//------tN
   auto predicted_trajectory_point_removed = removeFrontTrajectoryPoint(
     trajectory_points, modified_trajectory_points, predicted_trajectory_points);

122:
The comment in this code block explains the behavior of the removeFrontTrajectoryPoint function. However, the comment is not aligned properly and contains unnecessary whitespace characters. It would be better to reformat the comment for clarity and remove the extra spaces.

   // If last point of predicted_trajectory is behind of end of trajectory, erase points which are
   // behind trajectory last point and insert pNew along the predicted_trajectory
-  // predicted_trajectory:       p1-----//------pN-2-----pN-1-----pN
+  // predicted_trajectory:           p1-----//------pN-2-----pN-1-----pN
   // trajectory:                     t1-----//-----tN-1--tN
   // ↓
   // predicted_trajectory:           p1-----//------pN-2-pNew

// trajectory: t1--------//------tN
auto predicted_trajectory_point_removed = removeFrontTrajectoryPoint(
trajectory_points, modified_trajectory_points, predicted_trajectory_points);
Expand All @@ -119,7 +119,7 @@ Trajectory alignTrajectoryWithReferenceTrajectory(

// If last point of predicted_trajectory is behind of end of trajectory, erase points which are
// behind trajectory last point and insert pNew along the predicted_trajectory
// predicted_trajectory:     p1-----//------pN-2-----pN-1-----pN
// predicted_trajectory: p1-----//------pN-2-----pN-1-----pN
// trajectory: t1-----//-----tN-1--tN
// ↓
// predicted_trajectory: p1-----//------pN-2-pNew
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyoichi-sugahara
is this alignment ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!!!
zenkaku lol

Expand Down
2 changes: 1 addition & 1 deletion perception/map_based_prediction/images/inside_road.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class Tracker
const rclcpp::Time & time) const;

/*
* Pure virtual function
* Pure virtual function
*/

protected:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class Tracker
const rclcpp::Time & time) const;

/*
* Pure virtual function
* Pure virtual function
*/

protected:
Expand Down
6 changes: 3 additions & 3 deletions planning/behavior_path_avoidance_module/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This is a rule-based path planning module designed for obstacle avoidance.

This module is designed for rule-based avoidance that is easy for developers to design its behavior. It generates avoidance path parameterized by intuitive parameters such as lateral jerk and avoidance distance margin. This makes it possible to pre-define avoidance behavior.

In addition, the approval interface of behavior_path_planner allows external users / modules (e.g. remote operation) to intervene the decision of the vehicle behavior.  This function is expected to be used, for example, for remote intervention in emergency situations or gathering information on operator decisions during development.
In addition, the approval interface of behavior_path_planner allows external users / modules (e.g. remote operation) to intervene the decision of the vehicle behavior. This function is expected to be used, for example, for remote intervention in emergency situations or gathering information on operator decisions during development.

### Limitations

Expand Down Expand Up @@ -934,7 +934,7 @@ namespace: `avoidance.constraints.longitudinal.`
## Future extensions / Unimplemented parts

- **Planning on the intersection**
- If it is known that the ego vehicle is going to stop in the middle of avoidance execution (for example, at a red traffic light), sometimes the avoidance should not be executed until the vehicle is ready to move. This is because it is impossible to predict how the environment will change during the stop.  This is especially important at intersections.
- If it is known that the ego vehicle is going to stop in the middle of avoidance execution (for example, at a red traffic light), sometimes the avoidance should not be executed until the vehicle is ready to move. This is because it is impossible to predict how the environment will change during the stop. This is especially important at intersections.

![fig1](./images/intersection_problem.drawio.svg)

Expand All @@ -956,7 +956,7 @@ namespace: `avoidance.constraints.longitudinal.`
- Essentially, avoidance targets are judged based on whether they are static objects or not. For example, a vehicle waiting at a traffic light should not be avoided because we know that it will start moving in the future. However this decision cannot be made in the current Autoware due to the lack of the perception functions. Therefore, the current avoidance module limits the avoidance target to vehicles parked on the shoulder of the road, and executes avoidance only for vehicles that are stopped away from the center of the lane. However, this logic cannot avoid a vehicle that has broken down and is stopped in the center of the lane, which should be recognized as a static object by the perception module. There is room for improvement in the performance of this decision.

- **Resampling path**
- Now the rough resolution resampling is processed to the output path in order to reduce the computational cost for the later modules. This resolution is set to a uniformly large value  (e.g. `5m`), but small resolution should be applied for complex paths.
- Now the rough resolution resampling is processed to the output path in order to reduce the computational cost for the later modules. This resolution is set to a uniformly large value (e.g. `5m`), but small resolution should be applied for complex paths.

## How to debug

Expand Down
26 changes: 13 additions & 13 deletions planning/behavior_path_goal_planner_module/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ The main thread will be the one called from the planner manager flow.
| decide_path_distance | [m] | double | decide path if it approaches this distance relative to the parking position. after that, no path planning and goal search are performed | 10.0 |
| maximum_deceleration | [m/s2] | double | maximum deceleration. it prevents sudden deceleration when a parking path cannot be found suddenly | 1.0 |
| path_priority | [-] | string | In case `efficient_path` use a goal that can generate an efficient path which is set in `efficient_path_order`. In case `close_goal` use the closest goal to the original one. | efficient_path |
| efficient_path_order | [-] | string | efficient order of pull over planner along lanes excluding freespace pull over | ["SHIFT", "ARC_FORWARD", "ARC_BACKWARD"] |
| efficient_path_order | [-] | string | efficient order of pull over planner along lanes excluding freespace pull over | ["SHIFT", "ARC_FORWARD", "ARC_BACKWARD"] |

### **shift parking**

Expand Down Expand Up @@ -365,18 +365,18 @@ This method integrates the footprints of egos and objects at a given time and ch
In addition, the safety check has a time hysteresis, and if the path is judged "safe" for a certain period of time(`keep_unsafe_time`), it is finally treated as "safe".

```txt
   ==== is_safe
   ---- current_is_safe
   is_safe
   ^
   |
   | time
   1 +--+ +---+ +---========= +--+
   | | | | | | | |
   | | | | | | | |
   | | | | | | | |
   | | | | | | | |
   0 =========================-------==========--> t
==== is_safe
---- current_is_safe
is_safe
^
|
| time
1 +--+ +---+ +---========= +--+
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
0 =========================-------==========--> t
```

### Parameters for safety check
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class GoalSearcher : public GoalSearcherBase
GoalCandidates search() override;
void update(GoalCandidates & goal_candidates) const override;

// todo(kosuke55): Functions for this specific use should not be in the interface,
// todo(kosuke55): Functions for this specific use should not be in the interface,
// so it is better to consider interface design when we implement other goal searchers.
GoalCandidate getClosetGoalCandidateAlongLanes(
const GoalCandidates & goal_candidates) const override;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2020,17 +2020,17 @@
});

/*
*   ==== is_safe
*   ---- current_is_safe
*   is_safe
*   |
*   | time
*   1 +--+ +---+ +---========= +--+
*   | | | | | | | |
*   | | | | | | | |
*   | | | | | | | |
*   | | | | | | | |
*   0 =========================-------==========-- t
* ==== is_safe

Check warning on line 2023 in planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp

View check run for this annotation

Codecov / codecov/patch

planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp#L2023

Added line #L2023 was not covered by tests
* ---- current_is_safe
* is_safe
* |
* | time
* 1 +--+ +---+ +---========= +--+
* | | | | | | | |

Check warning on line 2029 in planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp

View check run for this annotation

Codecov / codecov/patch

planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp#L2029

Added line #L2029 was not covered by tests
* | | | | | | | |
* | | | | | | | |
* | | | | | | | |
* 0 =========================-------==========-- t

Check warning on line 2033 in planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp

View check run for this annotation

Codecov / codecov/patch

planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp#L2031-L2033

Added lines #L2031 - L2033 were not covered by tests
*/
if (current_is_safe) {
if (
Expand Down
2 changes: 1 addition & 1 deletion planning/behavior_path_lane_change_module/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ First, we divide the target objects into obstacles in the target lane, obstacles

![object lanes](./images/lane_objects.drawio.svg)

Furthermore, to change lanes behind a vehicle waiting at a traffic light, we skip the safety check for the stopping vehicles near the traffic light. The explanation for parked car detection is written in [documentation for avoidance module](../behavior_path_avoidance_module/README.md).
Furthermore, to change lanes behind a vehicle waiting at a traffic light, we skip the safety check for the stopping vehicles near the traffic light. The explanation for parked car detection is written in [documentation for avoidance module](../behavior_path_avoidance_module/README.md).

##### Collision check in prepare phase

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ void BehaviorPathPlannerNode::publish_reroute_availability() const
{
// In the current behavior path planner, we might encounter unexpected behavior when rerouting
// while modules other than lane following are active. If non-lane-following module except
// always-executable module is approved and running, rerouting will not be possible.
// always-executable module is approved and running, rerouting will not be possible.
RerouteAvailability is_reroute_available;
is_reroute_available.stamp = this->now();
if (planner_manager_->hasNonAlwaysExecutableApprovedModules()) {
Expand Down
10 changes: 5 additions & 5 deletions planning/behavior_velocity_occlusion_spot_module/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ The maximum slowdown velocity is calculated from the below parameters of ego cur
| `use_object_info` | bool | [-] whether to reflect object info to occupancy grid map or not. |
| `use_partition_lanelet` | bool | [-] whether to use partition lanelet map data. |

| Parameter /debug | Type | Description |
| ------------------------- | ---- | ---------------------------------------------- |
| `is_show_occlusion` | bool | [-] whether to show occlusion point markers.  |
| `is_show_cv_window` | bool | [-] whether to show open_cv debug window. |
| `is_show_processing_time` | bool | [-] whether to show processing time. |
| Parameter /debug | Type | Description |
| ------------------------- | ---- | -------------------------------------------- |
| `is_show_occlusion` | bool | [-] whether to show occlusion point markers. |
| `is_show_cv_window` | bool | [-] whether to show open_cv debug window. |
| `is_show_processing_time` | bool | [-] whether to show processing time. |

| Parameter /threshold | Type | Description |
| ----------------------- | ------ | --------------------------------------------------------- |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ bool MissionPlanner::check_reroute_safety(
* +-----------+-----------+-----------+-----------+-----------+
* | | | | | |
* +-----------+-----------+-----------+-----------+-----------+
*                original original original
* original original original
* target target target target target
*/
const auto original_front_primitives = original_route.segments.front().primitives;
Expand Down
Loading