Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mission_planner): add comment functions/remove unused stuff/add comment #6447

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 19, 2024

Description

  • added doxygen comments to functions
  • removed unused functions / replaced with existing utility functions
  • for check_goal_footprint, use boost::within instead

Related links

Tests performed

https://evaluation.tier4.jp/evaluation/reports/71566d0a-8f2d-556b-95b0-4ab69d7fd4d4?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…add comment

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 19, 2024
@soblin soblin marked this pull request as ready for review February 19, 2024 12:20
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -301 to -303
boost::geometry::intersection(
goal_footprint, combined_lanelets.polygon2d().basicPolygon(), points_intersection);
if (points_intersection.empty()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ismetatabay
If you have any reason to use intersection, please let us know.

#2088

@kosuke55
Copy link
Contributor

(please fix spell check)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 19, 2024
@soblin soblin enabled auto-merge (squash) February 19, 2024 22:27
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3f21683) 14.98% compared to head (e7ec3c5) 14.99%.
Report is 7 commits behind head on main.

Files Patch % Lines
...n_planner/src/lanelet2_plugins/default_planner.cpp 11.11% 6 Missing and 2 partials ⚠️
...planner/src/lanelet2_plugins/utility_functions.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6447   +/-   ##
=======================================
  Coverage   14.98%   14.99%           
=======================================
  Files        1839     1839           
  Lines      127213   127200   -13     
  Branches    38132    38124    -8     
=======================================
  Hits        19069    19069           
+ Misses      86809    86796   -13     
  Partials    21335    21335           
Flag Coverage Δ *Carryforward flag
differential 12.91% <10.00%> (?)
total 14.99% <ø> (+<0.01%) ⬆️ Carriedforward from 3f21683

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 640fa80 into autowarefoundation:main Feb 19, 2024
31 of 32 checks passed
@soblin soblin deleted the refactor/mission_planner branch February 19, 2024 23:28
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…add comment (autowarefoundation#6447)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…add comment (#6447)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…add comment (autowarefoundation#6447)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants