-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mission_planner): add comment functions/remove unused stuff/add comment #6447
refactor(mission_planner): add comment functions/remove unused stuff/add comment #6447
Conversation
…add comment Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
boost::geometry::intersection( | ||
goal_footprint, combined_lanelets.polygon2d().basicPolygon(), points_intersection); | ||
if (points_intersection.empty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ismetatabay
If you have any reason to use intersection
, please let us know.
(please fix spell check) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
=======================================
Coverage 14.98% 14.99%
=======================================
Files 1839 1839
Lines 127213 127200 -13
Branches 38132 38124 -8
=======================================
Hits 19069 19069
+ Misses 86809 86796 -13
Partials 21335 21335
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…add comment (autowarefoundation#6447) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…add comment (#6447) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…add comment (autowarefoundation#6447) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
Related links
Tests performed
https://evaluation.tier4.jp/evaluation/reports/71566d0a-8f2d-556b-95b0-4ab69d7fd4d4?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.