refactor(mission_planner): add comment functions/remove unused stuff/add comment #6447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add comment Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
github-actions
bot
added
the
component:planning
soblin
requested review from
isamu-takagi,
kosuke55,
mitsudome-r,
TakaHoribe and
takayuki5168
as code owners
kosuke55
reviewed
Feb 19, 2024
Comment on lines
-301
to
-303
| boost::geometry::intersection( | ||
| goal_footprint, combined_lanelets.polygon2d().basicPolygon(), points_intersection); | ||
| if (points_intersection.empty()) { |
There was a problem hiding this comment.
@ismetatabay
If you have any reason to use intersection, please let us know.
|
(please fix spell check) |
soblin
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
=======================================
Coverage 14.98% 14.99%
=======================================
Files 1839 1839
Lines 127213 127200 -13
Branches 38132 38124 -8
=======================================
Hits 19069 19069
+ Misses 86809 86796 -13
Partials 21335 21335
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…add comment (autowarefoundation#6447) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
…add comment (#6447) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…add comment (autowarefoundation#6447) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
Tests performed
https://evaluation.tier4.jp/evaluation/reports/71566d0a-8f2d-556b-95b0-4ab69d7fd4d4?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.