Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_pcl_extensions): fix spell check #6434

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Feb 16, 2024

Description

  • fix covar -> cov
  • fix evals -> eigen_values
  • fix evecs -> eigen_vectors
  • fix getEvals -> getEigenValues
  • fix getEvecs -> getEigenVectors

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from RyuYamamoto as a code owner February 16, 2024 03:57
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 16, 2024
@h-ohta h-ohta enabled auto-merge (squash) February 16, 2024 05:45
@h-ohta h-ohta added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86b4335) 15.09% compared to head (19a5b84) 15.26%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6434      +/-   ##
==========================================
+ Coverage   15.09%   15.26%   +0.16%     
==========================================
  Files        1823     1821       -2     
  Lines      126342   124904    -1438     
  Branches    38200    38155      -45     
==========================================
- Hits        19077    19070       -7     
+ Misses      85871    84461    -1410     
+ Partials    21394    21373      -21     
Flag Coverage Δ *Carryforward flag
differential 5.07% <ø> (?)
total 15.29% <ø> (+0.19%) ⬆️ Carriedforward from 3df3280

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit 8e45709 into main Feb 26, 2024
23 of 24 checks passed
@h-ohta h-ohta deleted the fix/spell_check_pcl_ext branch February 26, 2024 09:25
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
* fix covar -> cov

* fix evals and evecs

* fix

* fix

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* fix covar -> cov

* fix evals and evecs

* fix

* fix

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* fix covar -> cov

* fix evals and evecs

* fix

* fix

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants