Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): expand the scope of spell-check-partial #6436

Closed
wants to merge 143 commits into from
Closed

chore(ci): expand the scope of spell-check-partial #6436

wants to merge 143 commits into from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Feb 16, 2024 •
edited
Loading

Description

Stop ignoring cspell errors in perception directory (except "perception/bytetrack/lib/**" ) in spell-check-partial workflow.
And ignore some words in "perception/bytetrack/src/**".

Tests performed

The spell-check-partial test passed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@HansRobo HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2024
@HansRobo HansRobo marked this pull request as ready for review March 7, 2024 02:05
@HansRobo HansRobo requested review from kminoda and h-ohta March 7, 2024 02:05
@HansRobo HansRobo enabled auto-merge (squash) March 7, 2024 02:05
h-ohta
h-ohta reviewed Mar 11, 2024
View reviewed changes
@HansRobo HansRobo disabled auto-merge March 12, 2024 01:10
@HansRobo HansRobo requested a review from manato as a code owner March 12, 2024 02:43
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 12, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.80%. Comparing base (5adc394) to head (74e5c8f).
Report is 3 commits behind head on main.

❗ Current head 74e5c8f differs from pull request most recent head 541328a. Consider uploading reports for the commit 541328a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6436      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1915     1915              
  Lines      132252   132251       -1     
  Branches    39317    39317              
==========================================
- Hits        19576    19575       -1     
  Misses      90845    90845              
  Partials    21831    21831
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.80% <ø> (-0.01%) ⬇️ Carriedforward from 5adc394

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Mar 12, 2024
HansRobo and others added 19 commits March 12, 2024 11:57
@HansRobo
chore(ci): expand the scope of spell-check-partial
5c92935 
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@pre-commit-ci @HansRobo
style(pre-commit): autofix
f5ac1f7 
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@soblin @HansRobo
feat(tier4_control_launch): run control_validator out of main control…
7a92f73 
… container (#6435)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@maxime-clem @HansRobo
fix(behavior_path_planner): catch exception when calculating curvature (
ebd85b4 
#6431)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@YamatoAndo @HansRobo
chore(gnss_poser): add maintainer (#6407)
e0b196b 
add maintainer

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@maxime-clem @HansRobo
docs(planning): add dynamic_obstacle_stop to the list of modules (#6389)
5b21df8 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@brkay54 @HansRobo
fix(obstacle_stop_planner): change the nearest_collision_point calcul…
a65c135 
…ation place (#5794)

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@badai-nguyen @pre-commit-ci @HansRobo
chore(image_projection_based_fusion): rename debug topics (#6418)
00ae8fb 
* chore(image_projection_based_fusion): rename debug topics

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* style(pre-commit): autofix

* fix: roi_pointcloud_fusion namespace

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@awf-autoware-bot @HansRobo
chore: update CODEOWNERS (#6396)
7fd1282 
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@satoshi-ota @HansRobo
feat(safety_check): add option to use polygon along path in safety ch…
3f1fa7f 
…eck (#6336)

* feat(safety_check): add new function to create polygon along path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): use free steer policy for safety check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(safety_check): fix polygon edge

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(safety_check): fix param name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@beyzanurkaya @HansRobo
refactor(obstacle_stop_planner): update package.xml (#6437)
1ccfd17 
refactor(obstacle_stop_planner): update package xml

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@kosuke55 @HansRobo
fix(goal_planner): fix updateCollisionCheckDebugMap timing in checkSa…
0a0870b 
…fetyWithIntegralPredictedPolygon (#6413)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@kyoichi-sugahara @HansRobo
chore(pointcloud_preprocessor): add maintainer (#6442)
de4c0bf 
add kyoichi sugahara as code owner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@takayuki5168 @HansRobo
feat!: move tools to autoware_tools repository (#6444)
9ef39d4 
feat: move tools to autoware_tools repository

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@zulfaqar-azmi-t4 @HansRobo
fix(lane_change): fix dynamic reconfigure and add parameters (#6276)
da0109c 
* fix(lane_change): fix dynamic reconfigure and add parameters

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* clear marker earlier

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@soblin @HansRobo
chore(tier4_control_launch): fix control validator name duplication (#…
c77fd04 
…6446)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@badai-nguyen @HansRobo
fix(blockage_diag): output blockage angle range bug fix (#6445)
f8ace07 
* fix: blockage_range_angle bug

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* Revert "chore: refactor"

This reverts commit fc43094.

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@tzhong518 @HansRobo
feat(traffic_light_multi_camera_fusion): take confidence into conside…
c437259 
…ration (#6267)

* fix: highest confidence

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: use the confidence of the first element

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@takayuki5168 @HansRobo
fix: revert accel_brake_map_calibrator (#6453)
530bc3a 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Mar 12, 2024
@HansRobo HansRobo closed this Mar 12, 2024
@HansRobo
Copy link
Member Author

Sorry for my miss operation 🙇
I'll close this pull-request and open another one.

@HansRobo HansRobo deleted the chore/stop_ignore_perception_spell_check branch June 6, 2024 13:51
@HansRobo HansRobo restored the chore/stop_ignore_perception_spell_check branch June 6, 2024 13:51
@HansRobo HansRobo deleted the chore/stop_ignore_perception_spell_check branch June 6, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-ohta h-ohta h-ohta left review comments

@kminoda kminoda Awaiting requested review from kminoda

@manato manato Awaiting requested review from manato

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@veqcc veqcc Awaiting requested review from veqcc

@TetsuKawa TetsuKawa Awaiting requested review from TetsuKawa

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@drwnz drwnz Awaiting requested review from drwnz

@knzo25 knzo25 Awaiting requested review from knzo25

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@amc-nu amc-nu Awaiting requested review from amc-nu

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@miursh miursh Awaiting requested review from miursh

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro SakodaShintaro is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@brkay54 brkay54 Awaiting requested review from brkay54

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

@tzhong518 tzhong518 Awaiting requested review from tzhong518

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto

@technolojin technolojin Awaiting requested review from technolojin technolojin is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@dan-dnn dan-dnn Awaiting requested review from dan-dnn

@ktro2828 ktro2828 Awaiting requested review from ktro2828

@scepter914 scepter914 Awaiting requested review from scepter914

@angry-crab angry-crab Awaiting requested review from angry-crab

@ambroise-arm ambroise-arm Awaiting requested review from ambroise-arm

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.