-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(start_planner): separate debug and info marker for rviz visualization #6376
Merged
kyoichi-sugahara
merged 2 commits into
autowarefoundation:main
from
kyoichi-sugahara:refactor/separate_debug_info_marker
Feb 11, 2024
Merged
refactor(start_planner): separate debug and info marker for rviz visualization #6376
kyoichi-sugahara
merged 2 commits into
autowarefoundation:main
from
kyoichi-sugahara:refactor/separate_debug_info_marker
Feb 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
wooo!! thanks!!!! |
kosuke55
approved these changes
Feb 11, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6376 +/- ##
==========================================
- Coverage 14.88% 14.88% -0.01%
==========================================
Files 1838 1838
Lines 126699 126708 +9
Branches 38042 38042
==========================================
Hits 18865 18865
- Misses 86535 86544 +9
Partials 21299 21299
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dcd29d3
into
autowarefoundation:main
31 of 34 checks passed
kyoichi-sugahara
added a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Feb 12, 2024
…alization (autowarefoundation#6376) * separate debug and info marker Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace util function for footprint Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…alization (autowarefoundation#6376) * separate debug and info marker Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace util function for footprint Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…alization (autowarefoundation#6376) * separate debug and info marker Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace util function for footprint Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally, all the start_planner specific information is visualized with the same topic of
/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/start_planner
.It becomes cluttered because everything is visualized by just enabling one checkbox as shown in the folloing screenshot.
After categorizing in this PR,
info marker's are
back_end_pose
start_pose
end_pose
static_collision_check_end_pose
static_collision_check_end_polygon
planner_type
filtered_objects
predicted_path_for_safety_check
ego_and_target_polygon_relation
ego_and_target_polygon_relation_text
ego_and_target_polygon_relation_cube
debug marker's are
refined_start_pose
full_path
backward_driving_path
start_pose_candidates
start_pose_candidates_idx
shift_path_footprint
ego_predicted_path_start_planner
departure_check_lanes_for_shift_pull_out_path
pull_out_lanes_for_static_objects_collision_check
object_debug_info
The basic concepts are as follows:
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.