Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_perception_msgs): rename traffic_signal to traffic_light #6375

Merged

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Feb 11, 2024

Description

  • Rename traffic_signal to traffic_light

Related Links

Tests performed

Confirmed that the perception function runs correctly with logging_simulator.launch.xml.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 11, 2024
@miursh miursh marked this pull request as draft February 11, 2024 04:35
@miursh miursh changed the title rename traffic_signal to traffic_light refactor(tier4_perception_msgs): rename traffic_signal to traffic_light Feb 11, 2024
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 11, 2024
@miursh miursh requested a review from mitsudome-r February 11, 2024 08:03
@miursh miursh marked this pull request as ready for review February 11, 2024 08:03
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r
Copy link
Member

In order to avoid build break, I'm bypassing the build-check as it was tested locally.

@mitsudome-r mitsudome-r merged commit 5244c95 into autowarefoundation:main Feb 13, 2024
25 of 27 checks passed
@miursh miursh deleted the refactor/rename_traffic_signal branch February 13, 2024 03:18
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…ht (autowarefoundation#6375)

* rename traffic_signal to traffic_light

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* style(pre-commit): autofix

* fix(crosswalk_traffic_light_estimator): remove unused include, readme

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* rename traffic_signal_array to traffic_light_array

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ht (autowarefoundation#6375)

* rename traffic_signal to traffic_light

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* style(pre-commit): autofix

* fix(crosswalk_traffic_light_estimator): remove unused include, readme

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* rename traffic_signal_array to traffic_light_array

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 10, 2024
…ht (autowarefoundation#6375)

* rename traffic_signal to traffic_light

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* style(pre-commit): autofix

* fix(crosswalk_traffic_light_estimator): remove unused include, readme

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* rename traffic_signal_array to traffic_light_array

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: t4-x2 <grp-acl-git-x2@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants