Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_perception_msgs): rename traffic_signal to traffic_light #112

Merged

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Feb 11, 2024

Description

  • Rename traffic_signal to traffic_light

Related Links

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh marked this pull request as draft February 11, 2024 04:35
@miursh miursh changed the title refactor(tier4_perception_msgs) : rename traffic_signal to traffic_light refactor(tier4_perception_msgs): rename traffic_signal to traffic_light Feb 11, 2024
@miursh miursh marked this pull request as ready for review February 11, 2024 08:03
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit a1664b3 into tier4:tier4/universe Feb 13, 2024
13 of 17 checks passed
@miursh miursh deleted the refactor/rename_traffic_signal branch February 13, 2024 03:17
TomohitoAndo pushed a commit that referenced this pull request Jul 11, 2024
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants