Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AEB): check empty path at low speed #6346

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 7, 2024

Description

AEB calculates empty path when ego is low speed, so empty check is necessary internally.

Related link

https://tier4.atlassian.net/browse/RT1-5170

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Feb 7, 2024
@soblin soblin marked this pull request as ready for review February 7, 2024 04:57
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6405516) 14.86% compared to head (a8a704e) 14.86%.
Report is 18 commits behind head on main.

Files Patch % Lines
control/autonomous_emergency_braking/src/node.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6346   +/-   ##
=======================================
  Coverage   14.86%   14.86%           
=======================================
  Files        1845     1845           
  Lines      126636   126636           
  Branches    37876    37876           
=======================================
  Hits        18823    18823           
  Misses      86655    86655           
  Partials    21158    21158           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.86% <ø> (+<0.01%) ⬆️ Carriedforward from 1d6da07

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/aeb/path-empty-check-at-low-speed branch from 715ecc1 to f2f4105 Compare February 8, 2024 09:17
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 7112a5b into autowarefoundation:main Feb 8, 2024
21 of 23 checks passed
@soblin soblin deleted the fix/aeb/path-empty-check-at-low-speed branch February 8, 2024 11:51
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 9, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Feb 9, 2024
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Apr 15, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants