Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_threshold_filter): delete default param in src #6308

Conversation

scepter914
Copy link
Contributor

Description

Delete default parameter in src of radar_threshold_filter.

Tests performed

Test by compile

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 5, 2024
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (c89f863) 14.36% compared to head (35127de) 14.36%.
Report is 8 commits behind head on main.

Files Patch % Lines
...eshold_filter_node/radar_threshold_filter_node.cpp 0.00% 0 Missing and 12 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6308   +/-   ##
=======================================
  Coverage   14.36%   14.36%           
=======================================
  Files        1907     1907           
  Lines      130136   130135    -1     
  Branches    37640    37639    -1     
=======================================
  Hits        18697    18697           
  Misses      90430    90430           
+ Partials    21009    21008    -1     
Flag Coverage Δ *Carryforward flag
differential 41.66% <0.00%> (?)
total 14.36% <ø> (+<0.01%) ⬆️ Carriedforward from c89f863

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit ca772a1 into autowarefoundation:main Feb 10, 2024
30 of 32 checks passed
@scepter914 scepter914 deleted the refactor/radar_threshold_filter_src_parameter branch February 10, 2024 05:15
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants