-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(intersection): add const to member functions, replace enum with class tag for occlusion #6299
Merged
soblin
merged 1 commit into
autowarefoundation:main
from
tier4:refactor/intersection/add-const
Feb 7, 2024
Merged
chore(intersection): add const to member functions, replace enum with class tag for occlusion #6299
soblin
merged 1 commit into
autowarefoundation:main
from
tier4:refactor/intersection/add-const
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6299 +/- ##
==========================================
- Coverage 14.90% 14.90% -0.01%
==========================================
Files 1817 1817
Lines 125466 125471 +5
Branches 37706 37707 +1
==========================================
Hits 18699 18699
- Misses 85751 85756 +5
Partials 21016 21016
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e01525a
to
8ae2cd2
Compare
057a3fd
to
c5ff0ac
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
c5ff0ac
to
01ea64a
Compare
takayuki5168
approved these changes
Feb 7, 2024
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 8, 2024
… class tag for occlusion (autowarefoundation#6299) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
7 tasks
shmpwk
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 8, 2024
feat(intersection): cherry-pick awf autowarefoundation#6328 + autowarefoundation#6299 + autowarefoundation#6325
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
… class tag for occlusion (autowarefoundation#6299) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
… class tag for occlusion (autowarefoundation#6299) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
… class tag for occlusion (autowarefoundation#6299) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
… class tag for occlusion (autowarefoundation#6299) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Nov 9, 2024
… class tag for occlusion (autowarefoundation#6299) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added
const
to member functions for readabilityTests performed
https://evaluation.tier4.jp/evaluation/reports/a40b1c77-0f2a-5017-95e8-f397bf4c3f25?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.