-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance_by_lane_change): loosen execution condition #6220
fix(avoidance_by_lane_change): loosen execution condition #6220
Conversation
d7553f6
to
0516282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0516282
to
bb2daf4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6220 +/- ##
==========================================
- Coverage 15.07% 15.07% -0.01%
==========================================
Files 1832 1832
Lines 126556 126589 +33
Branches 38214 38217 +3
==========================================
+ Hits 19076 19077 +1
- Misses 86089 86121 +32
Partials 21391 21391
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2bc22be
to
1d2cf9a
Compare
1d2cf9a
to
567541a
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
567541a
to
a2a42b3
Compare
2389c15
into
autowarefoundation:main
…undation#6220) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…undation#6220) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Description
Previous avoidance by lane change execution condition uses maximum_avoidance_distance. This cause AbLC to be difficult to be execution.
Also there is no way to know visually about the execution check area.
This PR aims to solve two things
length
for longitudinal distance.min_avoidance_length
is now used.isExecutionRequested
function is not too long.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.