Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_planning_simulator): add enable_road_slope_simulation param #5933

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

Add the parameter used to simulate slopes with the simple_planning_simulator.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Dec 22, 2023
@maxime-clem maxime-clem changed the title param(simple_planning_simulator): add enable_road_slope_simulation param feat(simple_planning_simulator): add enable_road_slope_simulation param Dec 22, 2023
Copy link

stale bot commented Feb 20, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Feb 20, 2024
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 20, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Feb 20, 2024
@maxime-clem maxime-clem enabled auto-merge (squash) February 20, 2024 09:11
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f63ad33) 15.29% compared to head (38a8c28) 15.41%.
Report is 436 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5933      +/-   ##
==========================================
+ Coverage   15.29%   15.41%   +0.11%     
==========================================
  Files        1750     1750              
  Lines      120380   120699     +319     
  Branches    36723    36912     +189     
==========================================
+ Hits        18408    18601     +193     
- Misses      81318    81420     +102     
- Partials    20654    20678      +24     
Flag Coverage Δ *Carryforward flag
differential 47.23% <ø> (?)
total 15.28% <ø> (-0.01%) ⬇️ Carriedforward from 1c5f38a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 3e12d13 into autowarefoundation:main Feb 20, 2024
23 of 25 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…am (autowarefoundation#5933)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…am (#5933)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…am (autowarefoundation#5933)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem deleted the add_slope_simulation_param branch June 28, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants