Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): enable to track large/small size object #5858

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 13, 2023

Description

Problem statement

Multi object tracker sometimes fails to track too large or small object due to size gate in association.
Currently, large/small objects are purged from association process so it will not appeared tracker output.

How should we manage large/small objects?

  • We do not want to ignore too small/large objects (really?)
  • Originally

How this PR works

This PR enables to track such objects as UNKNOWN class by replacing the object class when its size is not fit to the gate condition.

Related links

Partly reused the PR #5751.

Tests performed

Tested with Lsim.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 13, 2023
@YoshiRi YoshiRi marked this pull request as ready for review December 22, 2023 01:25
@YoshiRi YoshiRi requested a review from yukkysaito as a code owner December 22, 2023 01:25
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 14.40%. Comparing base (fa8424d) to head (c502e73).
Report is 431 commits behind head on main.

Files Patch % Lines
..._tracker/src/data_association/data_association.cpp 0.00% 19 Missing ⚠️
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5858      +/-   ##
==========================================
+ Coverage   14.37%   14.40%   +0.03%     
==========================================
  Files        1907     1906       -1     
  Lines      130072   129754     -318     
  Branches    37618    37390     -228     
==========================================
- Hits        18695    18692       -3     
+ Misses      90367    90171     -196     
+ Partials    21010    20891     -119     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.44% <ø> (+0.07%) ⬆️ Carriedforward from 8afcbed

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh miursh marked this pull request as draft December 27, 2023 08:46
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Jan 16, 2024

review memo

  • Do not add complexity to tracker_core node, move it toassociation function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi force-pushed the feat/separate_association_gate branch from 29866d2 to 8afcbed Compare February 1, 2024 15:00
Copy link

stale bot commented Apr 21, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants