Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_pointcloud_preprocessor): add pointcloud_densifier package #10226

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/add-pointcloud-densifier-pkg

1ce5514
Select commit
Loading
Failed to load commit list.
Open

feat(autoware_pointcloud_preprocessor): add pointcloud_densifier package #10226

Merge branch 'main' into feat/add-pointcloud-densifier-pkg
1ce5514
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 10, 2025 in 39s

CodeScene PR Check

Quality Gate Failed

Gates Failed
New code is healthy (2 new files with code health below 9.00)
Enforce critical code health rules (1 file with Bumpy Road Ahead)
Enforce advisory code health rules (2 files with Complex Method, Complex Conditional, Overall Code Complexity)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
New code is healthy Violations Code Health Impact
pointcloud_densifier_node.cpp 4 rules 10.00 → 7.65 Suppress
occupancy_grid.cpp 2 rules 10.00 → 8.82 Suppress
Enforce critical code health rules Violations Code Health Impact
pointcloud_densifier_node.cpp 1 critical rule 10.00 → 7.65 Suppress
Enforce advisory code health rules Violations Code Health Impact
pointcloud_densifier_node.cpp 3 advisory rules 10.00 → 7.65 Suppress
occupancy_grid.cpp 2 advisory rules 10.00 → 8.82 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional pointcloud_densifier_node.cpp: PointCloudDensifierNode::filterPointCloudByROI
  • Overall Code Complexity pointcloud_densifier_node.cpp
  • Complex Conditional occupancy_grid.cpp: OccupancyGrid::updateOccupancy
  • Complex Conditional occupancy_grid.cpp: OccupancyGrid::isOccupied
  • Complex Method occupancy_grid.cpp: OccupancyGrid::updateOccupancy
  • Complex Method pointcloud_densifier_node.cpp: PointCloudDensifierNode::filterPointCloudByROI
  • Complex Method pointcloud_densifier_node.cpp: PointCloudDensifierNode::paramCallback
  • Complex Method pointcloud_densifier_node.cpp: PointCloudDensifierNode::transformAndMergePreviousClouds
  • Bumpy Road Ahead pointcloud_densifier_node.cpp: PointCloudDensifierNode::filterPointCloudByROI
  • Bumpy Road Ahead pointcloud_densifier_node.cpp: PointCloudDensifierNode::transformAndMergePreviousClouds
  • Bumpy Road Ahead pointcloud_densifier_node.cpp: PointCloudDensifierNode::paramCallback

Annotations

Check warning on line 62 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/occupancy_grid.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

OccupancyGrid::updateOccupancy has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 51 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/occupancy_grid.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

OccupancyGrid::updateOccupancy has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 66 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/occupancy_grid.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

OccupancyGrid::isOccupied has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 191 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

PointCloudDensifierNode::filterPointCloudByROI has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 326 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

PointCloudDensifierNode::paramCallback has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 262 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

PointCloudDensifierNode::transformAndMergePreviousClouds has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 175 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

PointCloudDensifierNode::filterPointCloudByROI has 2 complex conditionals with 6 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 191 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

PointCloudDensifierNode::filterPointCloudByROI has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 262 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

PointCloudDensifierNode::transformAndMergePreviousClouds has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 326 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

PointCloudDensifierNode::paramCallback has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in sensing/autoware_pointcloud_preprocessor/src/pointcloud_densifier/pointcloud_densifier_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 6.14 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.