-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(colcon-build): source /opt/autoware/setup.sh if exists #337
feat(colcon-build): source /opt/autoware/setup.sh if exists #337
Conversation
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk -san, what do you think of removing the It's understandable to have them for the runtime images. At least, for the CI we don't use this folder at all and it introduces about 700MB additional space. |
I was not aware until now that the Also, if we decide to keep the |
I see, I would suggest removing autoware's |
@xmfcx Not only comment but also review this please 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to reduce the container image sizes, I'm opposed to relying on /opt/autoware in the CI.
And will work towards removing that folder to reduce the image size.
This folder is not used in the CI so far. And as I've stated in the PR that would make use of this:
There are better ways to overcome that issue.
I started installing to |
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Co-authored-by: Mete Fatih Cırıt <xmfcx@users.noreply.github.com>
Description
In the current
autoware
images, the build artifacts of Autoware are saved under/opt/autoware
.https://github.com/autowarefoundation/autoware/blob/main/docker/Dockerfile#L158
https://github.com/autowarefoundation/autoware/blob/main/docker/scripts/build_and_clean.sh#L15
Therefore, in order to reference these artifacts, it is necessary to source
/opt/autoware/setup.sh
.This PR makes that change. By doing so, it is expected to reduce unnecessary repository references in
build_depends.repos
and shorten the build time.Tests performed
colcon-build
action youtalk/autoware.core#2Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.