Alasql data type improvement #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update data types in alasql tables Changed numbers to numeric data type from strings. * Update sql_joins.md * Revert "Update sql_joins.md" This reverts commit dce6bd6. * Increment version number * Revert change to current version description
|
As far as I can tell, everything in SQL Basics works as expected, and there are no references to NULL values being "NA". |
|
@pm0kjp Could you take a look at the SQL intermediate changes? Once you do, we will have to change the macros to point back to main. |
|
I made a couple of small suggestions around the quiz. I struggled to understand the second question in the CASE/LIKE quiz so I did reword that, but I'm flexible! |
pm0kjp
requested changes
Mar 29, 2024
Co-authored-by: Joy Payton <pm0kjp@users.noreply.github.com>
Co-authored-by: Joy Payton <pm0kjp@users.noreply.github.com>
Co-authored-by: Joy Payton <pm0kjp@users.noreply.github.com>
Co-authored-by: Joy Payton <pm0kjp@users.noreply.github.com>
drelliche
commented
Mar 29, 2024
|
@pm0kjp These were all great suggestions, and I incorporated all of them. I have the change to point the macro back to main as a suggestion, and then I think it is ready to go (until its next revamp) |
Co-authored-by: drelliche <99294374+drelliche@users.noreply.github.com>
|
@drelliche I committed the change to point back to main. |
pm0kjp
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr changes two things about the data in the alasql tables:
undefinedinstead of the string 'NA'. This means that they no longer appear as NA in the tables, now those entries are blank, but they do actually serve as null values for AVG, MAX, MIN, etc.Heads up that the second change may impact some of the other SQL modules...
Also, note that zip can't be numeric because they all start with 0 up there in Massachusetts lol