Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type in SQL macro templates #884

Closed
drelliche opened this issue Jan 29, 2024 · 2 comments · Fixed by #886
Closed

Data type in SQL macro templates #884

drelliche opened this issue Jan 29, 2024 · 2 comments · Fixed by #886
Labels
bug Something isn't working -- includes broken links. 🔥 Urgent! 🔥 SQL Intermediate team-reported This issue was generated because of a staff report

Comments

@drelliche
Copy link
Contributor

Right now all of the data types in the alaSQL tables in the SQL macros used by the SQL modules and the Arcus Speaker Series are strings.

But in the SQL Intermediate module and webinar, we teach aggregate functions, some of which (SUM and AVG) cannot be usefully demoed using the tables that have only string data.

There are similarly issues with MAX, MIN, and COUNT when the "NA" values are the string "NA" rather than a null value.

This issue is urgent because we are giving the SQL Intermediate talk next week!

@drelliche drelliche added bug Something isn't working -- includes broken links. team-reported This issue was generated because of a staff report SQL Intermediate 🔥 Urgent! 🔥 labels Jan 29, 2024
@drelliche
Copy link
Contributor Author

drelliche commented Jan 29, 2024

Possibly useful links:

LiaScript alaSQL template

Information on defining column types in alasql

Information on NULL and undefinied in alasql

@rosemm
Copy link
Contributor

rosemm commented Jan 29, 2024

Information on date fields: https://github.com/AlaSQL/alasql/wiki/Date (I think we might want to use DATE instead of Date)

@drelliche drelliche linked a pull request Jan 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working -- includes broken links. 🔥 Urgent! 🔥 SQL Intermediate team-reported This issue was generated because of a staff report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants