Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing an error message when guest_id is set while using template in… #2036

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Missing an error message when guest_id is set while using template in… #2036

merged 1 commit into from
Apr 2, 2024

Conversation

bardielle
Copy link
Contributor

… vmware_guest module

SUMMARY

Fixes missing error message in when creating VM using vmware_guest module, with template, while setting the guest_id parameter.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module vmware_guest

ADDITIONAL INFORMATION
---
- name: Run the first VM creation on vmware
  hosts: localhost
  gather_facts: true

  tasks:
  - name: Provision VM
    community.vmware.vmware_guest:
      hostname: "..."
      username: "..."
      password: "..."
      validate_certs: false

      cluster: "..."
      folder: "..."
      datacenter: "..."
      name: "vm-test-2"
      disk:
        - size_gb: 16
          type: thin
          datastore: "..."
      hardware:
        memory_mb: 512
        num_cpus: 4
      guest_id: "centos64Guest"
      template: "dbarda"

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e721ed2699a643068c0932cb2a1839ea

❌ ansible-tox-linters FAILURE in 10m 39s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@bardielle
Copy link
Contributor Author

/recheck

@bardielle
Copy link
Contributor Author

recheck

@bardielle bardielle force-pushed the fix_vmware_guest_template branch from f25c370 to 9b833ae Compare March 27, 2024 12:56
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9679f628414d44348b0a3a6c1f9f246c

✔️ ansible-tox-linters SUCCESS in 12m 55s
✔️ build-ansible-collection SUCCESS in 12m 53s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 22m 01s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable216 FAILURE in 22m 55s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 11s

@bardielle
Copy link
Contributor Author

cc @mariolenz

@mariolenz
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

@bardielle Is there an issue this would fix? If so, please add Fixes #nnn on he top of your PR. Or at the very least, mention the issue somewhere.

BTW the CI failure doesn't look related to your changes. This is something that turns up from time to time. I've issued a recheck, let's see if it works now.

@mariolenz
Copy link
Collaborator

@bardielle Please add a changelog fragment.

I wonder why you didn't. I looks like you're working for Red Hat, you should know that this is a requirement...

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8ffeae6d085f43b2939a8f7b550c4868

✔️ ansible-tox-linters SUCCESS in 12m 26s
✔️ build-ansible-collection SUCCESS in 11m 41s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 25m 44s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 22m 51s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 55m 27s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 53m 34s
✔️ ansible-galaxy-importer SUCCESS in 5m 13s

@bardielle
Copy link
Contributor Author

@mariolenz This is a bug fix for a Jira ticket that our QEs opened.
Do you prefer me to open a GitHub issue for that ticket?

Regarding the missing changelog file, you're right, I will add it, still learning this area.

@bardielle bardielle force-pushed the fix_vmware_guest_template branch from 9b833ae to 6b05e8c Compare March 31, 2024 06:09
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/64c8f7408eec4e62837a1c3777874ec1

✔️ ansible-tox-linters SUCCESS in 12m 24s
✔️ build-ansible-collection SUCCESS in 12m 26s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 20m 02s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 18m 29s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 48m 26s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 58m 59s
✔️ ansible-galaxy-importer SUCCESS in 4m 55s

@mariolenz
Copy link
Collaborator

Sorry, for the late reply, I've been AFK a couple of days.

This is a bug fix for a Jira ticket that our QEs opened. Do you prefer me to open a GitHub issue for that ticket?

No, I just wanted to know if this would close an existing issue. I'm no friend of creating an issue for the sake of having on ;-)

However, since there's no issue to mention in the changelog fragment you should mention this PR. This might help people to find more information about the change.

still learning this area.

No problem 😃

I didn't have a closer look at your code, though, but I'll try to do it soon.

@bardielle
Missing an error message when guest_id is set while using template in…
fd7775b 
… vmware_guest module

Signed-off-by: Danielle Barda <dbarda@redhat.com>
@bardielle bardielle force-pushed the fix_vmware_guest_template branch from 6b05e8c to fd7775b Compare April 2, 2024 11:42
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/187090c59af4493a87b31ece73477416

✔️ ansible-tox-linters SUCCESS in 14m 14s
✔️ build-ansible-collection SUCCESS in 15m 00s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 22m 37s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 20m 49s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 52m 26s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 56m 33s
✔️ ansible-galaxy-importer SUCCESS in 5m 53s

mariolenz
mariolenz approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @bardielle!

@mariolenz mariolenz added bug This issue/PR relates to a bug mergeit labels Apr 2, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/7f6579c4e69d4a90955103a09907d61a

✔️ ansible-tox-linters SUCCESS in 17m 03s
✔️ build-ansible-collection SUCCESS in 14m 09s
✔️ ansible-galaxy-importer SUCCESS in 5m 12s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5fa0fb7 into ansible-collections:main Apr 2, 2024
13 checks passed
This was referenced Apr 2, 2024
Merged
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 7, 2024
@mariolenz
stable-3.x: Missing error msg in vmware_guest (#2040)
1c72c24 
stable-3.x: Missing error msg in vmware_guest

SUMMARY
Fixes missing error message in when creating VM using vmware_guest module, with template, while setting the guest_id parameter.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
Backport of #2036

Reviewed-by: Danielle Barda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bardielle @mariolenz