-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vmware_all_snapshots_info new module #2029
Conversation
Build failed. ❌ ansible-tox-linters FAILURE in 10m 17s |
Why you close and open new PR? Please don't do that! If your PR don't build, you can add fixes (commits) in your branch and build will be relaunched automatically. If need run build in manual mode, you can just write commentary with word |
And don't be shy to ask for advice. |
Thank you so much ihumster !! I didn't know how this test was working, I will now post the new code |
@valkiriaaquatica The summery of the failed CI job doesn't look really helpful. But if you look at the log, there are a lot of whitespace issues. Maybe this helps. Just click on the failed job ( |
Build failed. ❌ ansible-tox-linters FAILURE in 11m 02s |
Build failed. ❌ ansible-tox-linters FAILURE in 10m 42s |
@valkiriaaquatica you also can use |
Co-authored-by: Mario Lenz <m@riolenz.de>
BTW I hope you don't see the CI as an enemy. It's your / our friend helping us to keep the collection healthy ;-) |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 11m 24s |
thanks @mariolenz and @ihumster for being so helpful! I passed the ansible-doc and andible-test sanity and of course test the module, so i thought that testing was valid but didn´t count on whitespaces to be honest |
Build failed. ✔️ ansible-tox-linters SUCCESS in 11m 02s |
recheck |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 10m 21s |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 16m 50s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 17m 09s |
@valkiriaaquatica I don't understand why the CI failes here, and failed again. Anyway, while I'm trying to find out what's going on here could you please add the new module |
Build failed.
|
recheck |
Build failed.
|
Hi @mariolenz can i now why you closed it? |
I'm hoping closing and re-opening would help. Nothing against your PR, just trying to make the CI succeed ;-)
Me neither. At the moment, it looks more like an issue in our CI pipeline and no problem with your code. As I've said, I wanted to try if closing and re-opening helps. |
Build failed.
|
I don't understand why |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 14m 45s |
recheck |
Build failed. ❌ ansible-tox-linters RETRY_LIMIT in 7m 31s |
recheck |
Build failed.
|
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 43s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 55s |
recheck |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 9m 37s |
@mariolenz I see the CI is working, the problem was with Zool? Because I saw that you uploaded versions of the CI packages but it was still crashing and then suddenly it worked, btw thanks for the attention :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @valkiriaaquatica!
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 9m 40s |
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
SUMMARY
The new module returns all snapshots in the datacenter with no need of indicating from where machine or folder they have to belong. It also lhas filters options that can be sctrict or included, based if the user wants to retrieve all snapshots that in their name contains the word "test" or all snapshots that their state is "poweredOn". There is no need to filter, if no filter is applied it just returns all snapshots.
ISSUE TYPE
COMPONENT NAME
vmware_all_snapshots_info
ADDITIONAL INFORMATION
With the actual module community.vmware.vmware_guest_snapshot_info the user needs to write or if the uuid or the moid is not supplied, also no filters can be applied. With this module all snapshots of th vmware are returned by default and one or more filters can be aplpied.
Below to get all snapshtos of the datacenter and then filter
New approach