Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::sync::OnceLock instead of once_cell::sync::Lazy #725

Closed
wants to merge 1 commit into from

Conversation

rmg-x
Copy link
Contributor

@rmg-x rmg-x commented Feb 10, 2024

This PR removes the once_cell dependency and uses the std struct instead.
MSRV would go up to 1.70

See:

@algesten
Copy link
Owner

Hi @rmg-x, welcome to ureq!

I do agree it would be nice to do this, but at this point we can't bump the MSRV. We decided on a rather conservative version requirement since our users have that need. See this issue from just two weeks ago: #712 - this was due to trying to use let-else syntax.

@DanGould
Copy link
Contributor

Second the msrv concern, other than just being simple and correct, the reason I use ureq is because it builds on my target msrv 1.63.0

@rmg-x
Copy link
Contributor Author

rmg-x commented Mar 27, 2024

I can understand the concerns (because who wants their project to break?) but personally think it's the wrong approach for this library.

Eventually there will be a point where the MSRV is bumped and users will complain. I think it makes more sense to put the onus on people requiring a lower version (e.g. fork or use an older ureq version)

Regardless, I appreciate the responses and will leave the PR open, feel free to close it.

@rmg-x rmg-x mentioned this pull request Jul 8, 2024
@algesten
Copy link
Owner

Closing since we are moving to 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants