Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace once_cell to std impl #790

Closed
wants to merge 3 commits into from

Conversation

stackinspector
Copy link

I can't guarantee full equivalence of behavior, but at least it's conceptually equivalent. (The once_cell crate should write a migration guide!)
This will bump MSRV to 1.80. once_cell only needs 1.70, while lazy_cell needs 1.80. I originally thought only the former was needed, but then I saw the latter. The latter is a bit of a span, so it depends on you if you can accept it.
Bumped Rust edition to 2021 & removed redundant uses by the way.

@algesten
Copy link
Owner

Hi @stackinspector, thanks for this!

ureq will always be very conservative in MSRV.

We are not going to bump MSRV at this point. If you look at the numbers at the bottom (Usage of Rust versions based on crates.io requests): https://lib.rs/stats#rustc-usage you see that 1.67 is where we hit 99% of all users. If we were to bump to 1.80 that number drops to 49%.

Also a duplicate of #725

@algesten algesten closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants