Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selfheating #30

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Fix selfheating #30

merged 3 commits into from
Sep 30, 2020

Conversation

AnHardt
Copy link
Contributor

@AnHardt AnHardt commented Sep 29, 2020

Shut off bias current after one shot conversion to minimize self heating.
Fixing #1
Makes some 1/10°C for a 3mm diameter 10mm length cartridge in free not moving air at room temperature when called once per second. (even when called only every 10 seconds a difference is visible) (room thermometer) (it's sensor surface size dependent) (we produce about 1mA at 100 Ohm = 0,0001W = 0.1mW if always on) (if in a metal heater block or a liquid this is negligible, but not in air or less thermal conductive media )


A PR for "auto mode" with the bias current always on but without the busy waiting when waiting for stabilizing the bias current and waiting for the conversion will follow one day.

AnHardt and others added 2 commits September 29, 2020 23:02
Here we have a MAX318**65** not a MAX218**56**.
@AnHardt
Copy link
Contributor Author

AnHardt commented Sep 29, 2020

That's all for now.

@caternuson
Copy link
Contributor

It appears your 3 recent PRs are cumulative. #28 fixes the NULL pointer issue. #29 does that and fixes typo. This one does all that plus tweaks the heater.

Seem like we can only merge this one take care of all of these?

Did you test this PR, the one with ALL of the changes, also with your UNO?

@AnHardt
Copy link
Contributor Author

AnHardt commented Sep 30, 2020

Yes they are cumulative, but better separated than my previous #16 what was completely ignored. This way i hope to get a bit more feedback about what you like and what not.

Yes. Tested on UNO and DUE with various of my applications.
Only this PR (#30) makes a tiny functional difference requested in #1 .
#29 fixes a copy/pasted typo we have from the initial version on - requested in #15 .
#28 is the same fix like in the already merged ones for the MAX31856 and MAX31855.

@caternuson
Copy link
Contributor

Thanks. Cool. Let's merge this one then :)

@caternuson caternuson merged commit ef12b30 into adafruit:master Sep 30, 2020
@AnHardt AnHardt deleted the Fix_selfheating branch September 30, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants