Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAX31856_CONFIG_REG ??? #15

Closed
AnHardt opened this issue Feb 26, 2020 · 1 comment
Closed

MAX31856_CONFIG_REG ??? #15

AnHardt opened this issue Feb 26, 2020 · 1 comment

Comments

@AnHardt
Copy link
Contributor

AnHardt commented Feb 26, 2020

I know - this library is to abstract the #defines for the registers and bits in the registers away - the user should not need to use them.
However, the names for that should have the right IC-name in it.
All "MAX31856_*" have to be replaced by "MAX31865_*"
Here we are not dealing with the "MAX31856 Precision Thermocouple to Digital Converter
with Linearization" but the "MAX31865 RTD-to-Digital Converter".

And if the #defines are not thought to be used outside the library, should they be exported by the .h-file, or kept secret in the .cpp-file?
AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Mar 12, 2020
@AnHardt
Rename MAX31856 defines
8692ccd 
Most #defines are falsely named with MAX318**56**_* .
Rename them to MAX318**65**_*

Fixing adafruit#15
AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Mar 13, 2020
@AnHardt
MAX31856_* -> MAX31865_*
56e7343 
Replace all occurrences of "MAX31856_*" with "MAX31865_*"
Here we have a library for the "MAX318**65** RTD-to-Digital Converter". Not for the "MAX318**56** Precision Thermocouple to Digital Converter
with Linearization"

Fixing adafruit#15
This was referenced Mar 13, 2020
Closed
Closed
AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Sep 14, 2020
@AnHardt
MAX31856_* -> MAX31865_*
470a762 
Replace all occurrences of "MAX31856_*" with "MAX31865_*"
Here we have a library for the "MAX318**65** RTD-to-Digital Converter". Not for the "MAX318**56** Precision Thermocouple to Digital Converter
with Linearization"

Fixing adafruit#15
This was referenced Sep 29, 2020
Merged
Merged
@caternuson
Copy link
Contributor

Fixed with #30

@sylvanoMTL sylvanoMTL mentioned this issue Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AnHardt @caternuson