Clean up some old issues #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnHardt
force-pushed
the
AIO
branch
2 times, most recently
from
b7ddd19 to
85ee5e8
Compare
Disable bias-current after one-shot conversion to minimize self-heating. Resolving #1
Add the possibility to do a 'automatic fault-detection cycle' and use it during begin(). Using code from and fixing adafruit#5
Replace all occurrences of "MAX31856_*" with "MAX31865_*" Here we have a library for the "MAX318**65** RTD-to-Digital Converter". Not for the "MAX318**56** Precision Thermocouple to Digital Converter with Linearization" Fixing adafruit#15
Make use of the 'Fault bit' in the 'RTD Resistance Registers' to save some SPI-traffic. When reading the 'RTD Resistance Registers' we get the information if it makes sense to read the 'Fault Status Register' for free. We don't have to read the register over SPI if the register is empty anyway.
Normalize resistance before calculating temperature with the formula for the positive temperatures. Positive temperature means (when normalized) resistance > 100 Ohm. We then can decide what formula to use, before we calculated the positive one. This should significantly speed up the calculation for negative temperatures. Even more efficient would be to store the normalized value for Rref in the object - but that would change the API.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of a few patches fixing some long standing issues plus some other improvements.
Best reviewed commit by commit.
Disable bias-current after one-shot conversion
Disable bias-current after one-shot conversion to minimize self-heating.
Using code from @drhaney
Resolving #1
Add the possibility to do a 'automatic fault-detection cycle'
Add the possibility to do a 'automatic fault-detection cycle' and use it during begin().
Using code from @dl9sec and fixing #5
MAX31856_* -> MAX31865_*
Replace all occurrences of "MAX31856_" with "MAX31865_"
Here we have a library for the "MAX31865 RTD-to-Digital Converter". Not for the "MAX31856 Precision Thermocouple to Digital Converter
with Linearization"
Fixing my #15
Make use of the 'Fault bit' in the 'RTD Resistance Registers'
Make use of the 'Fault bit' in the 'RTD Resistance Registers' to save some SPI-traffic.
When reading the 'RTD Resistance Registers' we get the information if it makes sense to read the 'Fault Status Register' for free. We don't have to read the register over SPI if the register is empty anyway.
Normalize resistance before calculating positive temperature
Normalize resistance before calculating temperature with the formula for the positive temperatures.
Positive temperature means (when normalized) resistance >= 100 Ohm.
We then can decide what formula to use, before we calculated the positive one.
This should significantly speed up the calculation for negative temperatures.
Even more efficient would be to store the normalized value for Rref in the object - but that would change the API.