Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies vendoring, part 2 #1232

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

dependencies vendoring, part 2 #1232

wants to merge 20 commits into from
+1,381 −318

Conversation

PetrShumilov
Copy link
Contributor

@PetrShumilov PetrShumilov commented Feb 6, 2025 •
edited
Loading

Plan for libs:

  • Z lib
  • ZSTD
  • nghttp2
  • RE2
  • PCRE

Other activities:

  • Eliminate the use of the in-source build technique.
  • Provide two options for building dependencies: pic and no-pic.
  • Switch to using Debian's mirrors for as many libraries as possible.
  • Implement a patching mechanism.
  • Combine all dependencies and the KPHP runtime library into a single .a file.

@PetrShumilov PetrShumilov added enhancement New feature or request runtime Feature related to runtime CI/CD labels Feb 6, 2025
@PetrShumilov PetrShumilov added this to the next milestone Feb 6, 2025
@PetrShumilov PetrShumilov self-assigned this Feb 6, 2025
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part2 branch 3 times, most recently from db4de3b to 1fc7f06 Compare February 12, 2025 15:02
@Danil42Russia Danil42Russia modified the milestones: 17.02.2025, next Feb 17, 2025
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part2 branch 13 times, most recently from 4ea08ce to 7390e0a Compare February 18, 2025 14:29
@PetrShumilov
Add passing CFLAGS to third-parties
c74e1bc 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Remove BUILD_IN_SOURCE to keep third-party directories clean
3fc1aef 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add patch applying for OpenSSL
9d87bfb 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part2 branch 4 times, most recently from 34dc3e4 to 46a7abe Compare February 19, 2025 11:46
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part2 branch from a83a4cd to 11f4ca4 Compare February 27, 2025 14:30
@PetrShumilov
Introduce pic and no-pic build variants for zstd
e89b869 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Introduce pic and no-pic build variants for nghttp2
3356ba8 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Introduce pic and no-pic build variants for curl
c688744 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part2 branch from 7f36840 to c688744 Compare February 28, 2025 14:20
@PetrShumilov
Introduce pic and no-pic build variants for OpenSSL
4170aed 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Remove useless cmake files
0d97b39 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Remove unnecessary copying of third-party artifacts into objs/lib
c633d28 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part2 branch 9 times, most recently from 3e55e8e to 984b34c Compare March 3, 2025 10:19
@PetrShumilov
Add re2 vendoring
4be82e5 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part2 branch from 984b34c to 4be82e5 Compare March 3, 2025 10:30
@PetrShumilov PetrShumilov marked this pull request as ready for review March 3, 2025 11:55
@PetrShumilov PetrShumilov requested a review from a team as a code owner March 3, 2025 11:55
promo4ka
promo4ka previously approved these changes Mar 3, 2025
View reviewed changes
@PetrShumilov
Use target_compile_options instead of set_target_properties
0477f7e 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add pcre vendoring
365eca4 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
apolyakov
apolyakov reviewed Mar 4, 2025
View reviewed changes
cmake/external-libraries.cmake
@@ -66,6 +66,7 @@ else()
)
message(STATUS "---------------------")
FetchContent_MakeAvailable(h3)
set_target_properties(h3 PROPERTIES DOWNLOADED_LIBRARY 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a comment describing why is it needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apolyakov apolyakov apolyakov left review comments

@promo4ka promo4ka promo4ka left review comments

@astrophysik astrophysik Awaiting requested review from astrophysik

@mkornaukhov03 mkornaukhov03 Awaiting requested review from mkornaukhov03

@DrDet DrDet Awaiting requested review from DrDet

At least 1 approving review is required to merge this pull request.

Assignees

@PetrShumilov PetrShumilov

Labels
CI/CD enhancement New feature or request runtime Feature related to runtime
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
4 participants
@PetrShumilov @apolyakov @promo4ka @Danil42Russia