Use target_compile_options instead of set_target_properties

Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
VKCOM · Mar 3, 2025 · 0477f7e · 0477f7e
1 parent 4be82e5
commit 0477f7e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cmake/utils.cmake b/cmake/utils.cmake
@@ -34,17 +34,17 @@ function(vk_add_library_pic)
     add_library(${ARGV})
     set_target_properties(${ARGV0} PROPERTIES
             POSITION_INDEPENDENT_CODE 1
-            COMPILE_FLAGS "-fPIC"
     )
+    target_compile_options(${ARGV0} PRIVATE -fPIC)
     add_vk_library_to_pic_namespace(${ARGV0})
 endfunction()
 
 function(vk_add_library_no_pic)
     add_library(${ARGV})
     set_target_properties(${ARGV0} PROPERTIES
             POSITION_INDEPENDENT_CODE 0
-            COMPILE_FLAGS "-fno-pic -static"
     )
+    target_compile_options(${ARGV0} PRIVATE -fno-pic -static)
     add_vk_library_to_no_pic_namespace(${ARGV0})
 endfunction()
 

diff --git a/runtime-light/runtime-light.cmake b/runtime-light/runtime-light.cmake
@@ -44,7 +44,7 @@ set_target_properties(runtime-light-pic PROPERTIES LIBRARY_OUTPUT_DIRECTORY
                                                ${BASE_DIR}/objs)
 target_compile_options(
   runtime-light-pic PUBLIC -stdlib=libc++ -iquote ${GENERATED_DIR}
-                       ${THIRD_PARTY_INCLUDE} -fPIC -O3)
+                       ${THIRD_PARTY_INCLUDE} -O3)
 target_link_options(runtime-light-pic PUBLIC -stdlib=libc++ -static-libstdc++)
 # add statically linking libraries
 string(JOIN " " ABSEIL_LIBS ${ABSEIL_LIBS})