Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed differentiation for all interfaces, added generator. Also, adde… #16

Closed
wants to merge 6 commits into from

Conversation

Gabriel-Bottrill
Copy link
Collaborator

…d tests for differentiation

The following have all been completed:

  • All new or changed features have a related unit test.

  • The entire test suite passes.

  • No extra files have been added by mistake, i.e. .vscode.

  • Style guidelines have been followed.

  • All files have been formatted.

  • Documentation and version number (if applicable) have been updated.

  • All code changed has been clearly written and commented.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@Gabriel-Bottrill
Copy link
Collaborator Author

Gabriel-Bottrill commented May 16, 2024

@glassnotes, this is just a draft for now. I just moved over what I had and will need to change some stuff including adding the warning for adjoint-dif. I was wondering what you thought about adding a Python warning to the generator function so that whenever generator is called it throws a warning?

@glassnotes
Copy link
Contributor

adding a Python warning to the generator function

I would only put a warning if it pertains to some sort of deprecation / usage effect that the user could cause. This is just related to adjoint diff, right? If the documentation is clear and there is some warning thrown if a user tries to use adjoint diff specifically, then I don't see why more is needed. The generator exists and a user should be able to construct and inspect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants