Set default black lines #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glassnotes
approved these changes
May 16, 2024
There was a problem hiding this comment.
Thanks @Gabriel-Bottrill ! I made some other small adjustments to pin CI requirements (and corresponding adjustments). If this looks okay please go ahead and merge so that these changes can be pulled into #16 .
|
Looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The required line-length for this project is not the same as the default line length for black. It would be easier if default was set.
Description of the Change:
Added pyproject.toml file that sets default line length for black.
Benefits:
Easier to format code. Also, it is less confusing for other contributors to pass CI tests as they may not know the intended line length.
Possible Drawbacks:
Extra file in main folder.
Related GitHub Issues:
N/A