Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade decidim to 0.28 #37

Merged
merged 10 commits into from
Feb 18, 2025
Merged

Upgrade decidim to 0.28 #37

merged 10 commits into from
Feb 18, 2025

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Jan 17, 2025

Fixes #36

Copy link

gitguardian bot commented Jan 17, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9774313 Triggered Generic Password 5dfa8c0 .github/workflows/lint.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@fblupi
Copy link
Member Author

fblupi commented Jan 17, 2025

@HHassig you can continue working from here. Let's do the tasks below:

  • Remove jQuery from JS files
  • Lint JS files
  • Adapt views and cells to the 0.28 styling
  • Check everything is working as expected
  • Include some system specs

@HHassig
Copy link
Contributor

HHassig commented Jan 29, 2025

  • Placeholder texts instead of "Note Takers" and "Participants (en.yml i18 error)
  • Top note background color
  • Edit chapter dropdown menu
image

@fblupi fblupi requested a review from alexrlpz February 18, 2025 10:56
@fblupi fblupi merged commit e808196 into main Feb 18, 2025
3 checks passed
@fblupi fblupi deleted the deps/update-decidim-0.28 branch February 18, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants