Skip to content

Commit

Permalink
Upgrade decidim to 0.28 (#37)
Browse files Browse the repository at this point in the history 
* Upgrade decidim to 0.28

* Change from codecov to coveralls

* remove select2.css imports

* Updated notify conversation index view

* Edit chapter modal fixed and styles updated

* Change users selectors from select2 to tom-select

* Admin panel views and styles updated

* Last views fixed and first lint

* Tests fixed and lint

* Conversations view fixed and lint

---------

Co-authored-by: Harrison Hassig <harrisonhassig@gmail.com>
Co-authored-by: Alejandro Rueda <alejandro.rueda@nazaries.com>
  • Loading branch information
@fblupi @HHassig @alexrlpz
3 people authored Feb 18, 2025
1 parent 120d15e commit e808196
Show file tree
Hide file tree
Showing 68 changed files with 24,063 additions and 7,392 deletions.
92 changes: 91 additions & 1 deletion .erb-lint.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
---
glob: "app/{cells,views}/**/*.erb"
exclude:
- '**/vendor/**/*'
- '**/node_modules/**/*'

linters:
ExtraNewline:
Expand All @@ -7,6 +11,9 @@ linters:
FinalNewline:
enabled: true

RequireInputAutocomplete:
enabled: false

SpaceAroundErbTag:
enabled: true

Expand All @@ -15,17 +22,100 @@ linters:
allowed_types:
- text/javascript
- text/template
- text/x-jsrender

DeprecatedClasses:
enabled: true
addendum: "Please remove it from code."
rule_set:
- deprecated: ['process-content']
suggestion: "This class is deprecated. Please remove the surrounding element"
- deprecated: ['xlarge-[\w]*']
suggestion: "Foundation classes are deprecated."

Rubocop:
enabled: true

rubocop_config:
inherit_from:
- .rubocop.yml

AllCops:
DisabledByDefault: true

Layout/InitialIndentation:
Enabled: false

Lint/SymbolConversion:
Enabled: false

Layout/SpaceInsideParens:
Enabled: false

Layout/SpaceAfterColon:
Enabled: false

Lint/UselessAssignment:
Enabled: false

Layout/ArgumentAlignment:
Enabled: true

Layout/SpaceAfterComma:
Enabled: false

Layout/TrailingWhitespace:
Enabled: false

Layout/LeadingEmptyLines:
Enabled: false

Layout/SpaceBeforeComma:
Enabled: false

Style/Copyright:
Enabled: false

Style/FrozenStringLiteralComment:
Enabled: false

Style/StringLiterals:
EnforcedStyle: double_quotes

Layout/LineLength:
Enabled: false

Layout/FirstArgumentIndentation:
Enabled: false

Layout/SpaceInsideHashLiteralBraces:
Enabled: true

Layout/BlockAlignment:
Enabled: false

Layout/MultilineMethodCallBraceLayout:
Enabled: false

Layout/FirstArrayElementIndentation:
Enabled: false

Layout/TrailingEmptyLines:
Enabled: false

Naming/FileName:
Enabled: false

Rails/LinkToBlank:
Enabled: false

Naming/VariableName:
Enabled: false

Layout/MultilineMethodCallIndentation:
Enabled: true

Layout/IndentationWidth:
Enabled: false

Layout/MultilineAssignmentLayout:
Enabled: false
9 changes: 7 additions & 2 deletions .eslintignore
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
**/*{.,-}min.js
decidim-*/vendor/**/*.js
**/*{.,-}min.js.csslintrc
spec/decidim_dummy_app/**/*.js
development_app
**/node_modules/**
bundle.js
karma.conf.js
webpack.config.js
webpack.config.babel.js
entry.test.js
entry.js
*_manifest.js
coverage
vendor/bundle
237 changes: 1 addition & 236 deletions .eslintrc.json
View file
Original file line number Diff line number Diff line change
@@ -1,238 +1,3 @@
{
"env": {
"browser": true,
"es2021": true
},
"extends": [
"eslint:recommended",
"prettier"
],
"parserOptions": {
"ecmaVersion": 12,
"sourceType": "module"
},
"globals": {
"require": false,
"$": false,
"jQuery": false,
"Rails": false
},
"rules": {
"accessor-pairs": "error",
"array-bracket-spacing": "error",
"array-callback-return": "error",
"arrow-body-style": "off",
"arrow-parens": [
"error",
"always"
],
"arrow-spacing": [
"error",
{
"after": true,
"before": true
}
],
"block-scoped-var": "error",
"block-spacing": "off",
"callback-return": "error",
"class-methods-use-this": "off",
"comma-dangle": ["error", "never"],
"comma-spacing": [
"error",
{
"after": true,
"before": false
}
],
"comma-style": [
"error",
"last"
],
"complexity": "error",
"computed-property-spacing": [
"error",
"never"
],
"consistent-this": "error",
"curly": "error",
"default-case": "error",
"dot-location": "error",
"dot-notation": "error",
"eol-last": "error",
"func-call-spacing": "error",
"func-name-matching": "error",
"func-names": [
"error",
"never"
],
"generator-star-spacing": "error",
"global-require": "error",
"handle-callback-err": "error",
"id-blacklist": "error",
"id-match": "error",
"indent": ["error", 2, { "VariableDeclarator": 2 }],
"jsx-quotes": "error",
"key-spacing": "error",
"keyword-spacing": [
"error",
{
"after": true,
"before": true
}
],
"linebreak-style": [
"error",
"unix"
],
"lines-around-comment": "error",
"lines-around-directive": "error",
"max-len": "off",
"max-lines": "error",
"max-nested-callbacks": "error",
"max-params": "error",
"max-statements": "off",
"max-statements-per-line": "error",
"multiline-ternary": "error",
"new-cap": "error",
"new-parens": "error",
"newline-after-var": "off",
"newline-before-return": "off",
"newline-per-chained-call": "off",
"no-alert": "error",
"no-array-constructor": "error",
"no-bitwise": "error",
"no-caller": "error",
"no-catch-shadow": "error",
"no-confusing-arrow": "error",
"no-continue": "error",
"no-div-regex": "error",
"no-duplicate-imports": "error",
"no-else-return": "error",
"no-eq-null": "error",
"no-eval": "error",
"no-extend-native": "error",
"no-extra-bind": "error",
"no-extra-label": "error",
"no-extra-parens": "off",
"no-floating-decimal": "error",
"no-implicit-coercion": "error",
"no-implicit-globals": "error",
"no-implied-eval": "error",
"no-iterator": "error",
"no-label-var": "error",
"no-labels": "error",
"no-lone-blocks": "error",
"no-lonely-if": "error",
"no-magic-numbers": "off",
"no-mixed-requires": "error",
"no-multi-spaces": "off",
"no-multi-str": "error",
"no-multiple-empty-lines": "error",
"no-native-reassign": "error",
"no-negated-condition": "error",
"no-negated-in-lhs": "error",
"no-nested-ternary": "error",
"no-new": "error",
"no-new-func": "error",
"no-new-object": "error",
"no-new-require": "error",
"no-new-wrappers": "error",
"no-octal-escape": "error",
"no-path-concat": "error",
"no-plusplus": "error",
"no-process-env": "error",
"no-process-exit": "error",
"no-proto": "error",
"no-prototype-builtins": "error",
"no-restricted-globals": "error",
"no-restricted-imports": "error",
"no-restricted-modules": "error",
"no-restricted-properties": "error",
"no-restricted-syntax": "error",
"no-return-assign": "error",
"no-script-url": "error",
"no-self-compare": "error",
"no-sequences": "error",
"no-shadow": "error",
"no-shadow-restricted-names": "error",
"no-spaced-func": "error",
"no-sync": "error",
"no-tabs": "error",
"no-template-curly-in-string": "error",
"no-throw-literal": "error",
"no-trailing-spaces": "off",
"no-undef-init": "error",
"no-undefined": "error",
"no-underscore-dangle": "off",
"no-unmodified-loop-condition": "error",
"no-unneeded-ternary": "error",
"no-unused-expressions": "error",
"no-use-before-define": "error",
"no-useless-call": "error",
"no-useless-computed-key": "error",
"no-useless-concat": "error",
"no-useless-constructor": "error",
"no-useless-escape": "error",
"no-useless-rename": "error",
"no-var": "error",
"no-void": "error",
"no-warning-comments": "error",
"no-whitespace-before-property": "error",
"no-with": "error",
"object-curly-newline": "off",
"object-curly-spacing": "off",
"object-property-newline": [
"error",
{
"allowMultiplePropertiesPerLine": true
}
],
"object-shorthand": "off",
"one-var": "off",
"one-var-declaration-per-line": "error",
"operator-assignment": "error",
"operator-linebreak": "error",
"padded-blocks": "off",
"prefer-arrow-callback": "off",
"prefer-const": "off",
"prefer-numeric-literals": "error",
"prefer-rest-params": "error",
"prefer-spread": "error",
"prefer-template": "error",
"quote-props": "off",
"quotes": ["error", "double", { "avoidEscape": true }],
"require-jsdoc": "error",
"rest-spread-spacing": "error",
"semi": "off",
"semi-spacing": "error",
"sort-imports": "off",
"sort-keys": "off",
"space-before-blocks": "error",
"space-before-function-paren": "off",
"space-in-parens": [
"error",
"never"
],
"space-infix-ops": "error",
"space-unary-ops": "error",
"spaced-comment": [
"error",
"always"
],
"strict": "error",
"symbol-description": "error",
"template-curly-spacing": "error",
"unicode-bom": [
"error",
"never"
],
"vars-on-top": "error",
"wrap-iife": "error",
"wrap-regex": "error",
"yield-star-spacing": "error",
"yoda": "error",
"import/no-named-as-default": "off",
"import/no-extraneous-dependencies": "off"
}
"extends": ["@decidim"]
}
Loading

0 comments on commit e808196

Please sign in to comment.